Skip to content

Add scipy.linalg.lu() decomposition support#2787

Merged
antonwolfy merged 27 commits intoIntelPython:masterfrom
abagusetty:linalg_lu
Mar 4, 2026
Merged

Add scipy.linalg.lu() decomposition support#2787
antonwolfy merged 27 commits intoIntelPython:masterfrom
abagusetty:linalg_lu

Conversation

@abagusetty
Copy link
Contributor

@abagusetty abagusetty commented Feb 27, 2026 •
edited by antonwolfy
Loading

This PR adds dpnp.scipy.linalg.lu() with support for all three output modes: default (P, L, U), permute_l=True (PL, U), and p_indices=True (p, L, U), including batched inputs.

Fixes: #2786

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@intel-python-devops
Copy link

intel-python-devops commented Feb 27, 2026

Can one of the admins verify this patch?

@antonwolfy antonwolfy added this to the 0.20.0 release milestone Mar 2, 2026
antonwolfy
antonwolfy reviewed Mar 2, 2026
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abagusetty, thank you for the contribution. I posted few comments below

abagusetty and others added 4 commits March 2, 2026 09:18
@abagusetty @antonwolfy
Update dpnp/scipy/linalg/_utils.py
67314b7 
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
@abagusetty @antonwolfy
Update dpnp/scipy/linalg/_utils.py
384618b 
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
@abagusetty
udapte CHANGELOG
5b83946
@abagusetty
address comments from PR
7161aef
@abagusetty
Copy link
Contributor Author

abagusetty commented Mar 2, 2026

@antonwolfy Thanks for taking time. All the suggestions were addressed. Please let me know

@coveralls
Copy link
Collaborator

coveralls commented Mar 3, 2026 •
edited
Loading

Coverage Status

coverage: 81.167% (+0.04%) from 81.124%
when pulling 69c51d8 on abagusetty:linalg_lu
into 7803d3a on IntelPython:master.

antonwolfy
antonwolfy reviewed Mar 3, 2026
View reviewed changes
abagusetty and others added 6 commits March 3, 2026 09:46
@abagusetty @antonwolfy
Update dpnp/tests/test_linalg.py
6e94734 
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
@abagusetty @antonwolfy
Update dpnp/tests/test_linalg.py
aa985e1 
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
@abagusetty @antonwolfy
Update dpnp/tests/test_linalg.py
05e3a0f 
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
@abagusetty @antonwolfy
Update CHANGELOG.md
c7a117a 
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
@abagusetty @antonwolfy
Update dpnp/scipy/linalg/_utils.py
4bc7226 
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
@abagusetty @antonwolfy
Update dpnp/tests/test_linalg.py
643f34d 
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
abagusetty and others added 6 commits March 3, 2026 09:47
@abagusetty @antonwolfy
Update dpnp/tests/test_linalg.py
28f26eb 
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
@abagusetty
Merge branch 'master' into linalg_lu
35a6c6e
@abagusetty @antonwolfy
Update dpnp/tests/test_linalg.py
aa00062 
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
@abagusetty @antonwolfy
Update dpnp/tests/test_linalg.py
9654380 
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
@abagusetty @antonwolfy
Update dpnp/tests/test_linalg.py
5de153d 
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
@abagusetty
Fix the test_linalg.py, add a test for scalar
69c51d8
antonwolfy
antonwolfy approved these changes Mar 4, 2026
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abagusetty, thank you a lot for the contribution.
All tests are passing and I'm going to merge the PR.

@antonwolfy antonwolfy merged commit 2c86497 into IntelPython:master Mar 4, 2026
96 of 97 checks passed
github-actions bot added a commit that referenced this pull request Mar 4, 2026
@github-actions
Add scipy.linalg.lu() decomposition support (#2787)
bec1933 
This PR adds `dpnp.scipy.linalg.lu()` with support for all three output
modes: default `(P, L, U)`, `permute_l=True (PL, U)`, and
`p_indices=True` `(p, L, U)`, including batched inputs.

Fixes: #2786 2c86497
@abagusetty abagusetty deleted the linalg_lu branch March 5, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.20.0 release

Development

Successfully merging this pull request may close these issues.

dpnp.scipy.linalg.lu missing although lu_factor / lu_solve are implemented

4 participants

@abagusetty @intel-python-devops @coveralls @antonwolfy