Skip to content

Extend ._tensor_impl with where(), clip() and type utils functions#2778

Merged
vlad-perevezentsev merged 91 commits intoinclude-dpctl-tensorfrom
move_tensor_impl_repeat_where_clip
Mar 5, 2026
Merged

Extend ._tensor_impl with where(), clip() and type utils functions#2778
vlad-perevezentsev merged 91 commits intoinclude-dpctl-tensorfrom
move_tensor_impl_repeat_where_clip

Conversation

@vlad-perevezentsev
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev commented Feb 20, 2026 •
edited
Loading

This PR extends _tensor_impl in dpctl_ext.tensor with the _where, _clip and repeat functions
(_repeat_by_sequence, _repeat_by_scalar)

It also adds repeat(), where(), clip() and can_cast, finfo, iinfo, isdtype, result_type from _type_utils.py `to dpctl_ext.tensor and updates the corresponding dpnp functions to use these implementations internally

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vlad-perevezentsev
Rename folder dpctl to dpctl_ext
d4fd805
@vlad-perevezentsev
Add simplify_iteration_space implementation to libtensor
c040713
@vlad-perevezentsev
Extend codespell ignore list for libtensor
14b466f
@vlad-perevezentsev
Add copy_and_cast kernels to libtensor
dcc421b
@vlad-perevezentsev
Add copy_usm_ndarray_into_usm_ndarray implementation
5a9c14c
@vlad-perevezentsev
Add pybind11 bindings for dpctl_ext.tensor._tensor_impl
4f63340
@vlad-perevezentsev
Add CMake build files for dpctl_ext
634579c
@vlad-perevezentsev
Add empty __init__ to dpctl_ext/
79d40f2
@vlad-perevezentsev
Enable _same_logical_tensors in _tensor_impl
7949c17
@vlad-perevezentsev
Add device_support_queries to enable default device types
29d6c02
@vlad-perevezentsev
Enable building and packaging of dpctl_ext
936e719
@vlad-perevezentsev
Use _tensor_impl from dpctl_ext.tensor in dpnp
cd85f1e
@vlad-perevezentsev
Move put() and take() to dpctl_ext/tensor
0c6780a
@vlad-perevezentsev
Use put/take from dpctl_ext.tensor in dpnp
87e5482
@vlad-perevezentsev
Move full() to dpctl_ext/tensor
b537f30
@vlad-perevezentsev
Use full and _full_usm_ndarray from dpctl_ext in dpnp
d50f263
@vlad-perevezentsev
Update .gitignore to ignore .so files in dpctl_ext
f189dc5
@vlad-perevezentsev
Move _zeros_usm_ndarray to dpctl_ext
f9a1817
@vlad-perevezentsev
Use _zeros_usm_ndarray from dpctl_ext in dpnp_fill.py
4b8505a
@vlad-perevezentsev
Move linear-sequence implementations to dpctl_ext/tensor
61106b2
@vlad-perevezentsev
Use _tensor_impl from dpctl_ext in dpnp_utils_fft.py
a030579
@vlad-perevezentsev
Move tril()/triu() to dpctl_ext/tensor
a1d6fa3
@vlad-perevezentsev
Use tril/triu/_tril from dpctl_ext.tensor in dpnp
f1d6e56
@vlad-perevezentsev
Disable pylint no-name-in-module for dpctl_ext
6680790
@vlad-perevezentsev
Add TODO comments
263b717
@vlad-perevezentsev
Use default_device_complex_type from dpctl_ext on test_array_api_info.py
4130c1b
@vlad-perevezentsev
Remove unused build_dpctl_ext function
17ca9ab
@vlad-perevezentsev
Apply remarks for CMake files
79cb2a4
@vlad-perevezentsev
Apply remarks for c++ files
4bf080e
@vlad-perevezentsev
Remove linear-sequence implementations
cfa6cd6
@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2026 •
edited
Loading

Array API standard conformance tests for dpnp=0.20.0dev3=py313h509198e_100 ran successfully.
Passed: 1355
Failed: 2
Skipped: 16

@vlad-perevezentsev vlad-perevezentsev marked this pull request as ready for review February 20, 2026 16:22
@vlad-perevezentsev vlad-perevezentsev mentioned this pull request Feb 23, 2026
Open
ndgrigorian
ndgrigorian previously approved these changes Mar 2, 2026
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from move_tensor_impl_accum_bool_ind_eye to include-dpctl-tensor March 3, 2026 13:39
@vlad-perevezentsev vlad-perevezentsev dismissed ndgrigorian’s stale review March 3, 2026 13:39

The base branch was changed.

antonwolfy
antonwolfy reviewed Mar 3, 2026
View reviewed changes
antonwolfy
antonwolfy reviewed Mar 4, 2026
View reviewed changes
antonwolfy
antonwolfy previously approved these changes Mar 4, 2026
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All other LGTM!

@vlad-perevezentsev vlad-perevezentsev merged commit 0edd3b1 into include-dpctl-tensor Mar 5, 2026
70 of 77 checks passed
@vlad-perevezentsev vlad-perevezentsev deleted the move_tensor_impl_repeat_where_clip branch March 5, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@ndgrigorian ndgrigorian ndgrigorian left review comments

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vlad-perevezentsev @ndgrigorian @antonwolfy