Skip to content

Extend ._tensor_impl with advanced indexing functions#2777

Merged
vlad-perevezentsev merged 64 commits intoinclude-dpctl-tensorfrom
move_tensor_impl_accum_bool_ind_eye
Mar 3, 2026
Merged

Extend ._tensor_impl with advanced indexing functions#2777
vlad-perevezentsev merged 64 commits intoinclude-dpctl-tensorfrom
move_tensor_impl_accum_bool_ind_eye

Conversation

@vlad-perevezentsev
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev commented Feb 19, 2026

This PR extends _tensor_impl in dpctl_ext.tensor with theadvanced indexing (_extract, _place, _nonzero, mask_positions, ), repeat (_cumsum_1d) and _eye functions

It also adds eye(), extract(), nonzero(), place(), put_along_axis(), take_along_axis() to dpctl_ext.tensor and updates the corresponding dpnp functions to use these implementations internally

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vlad-perevezentsev
Rename folder dpctl to dpctl_ext
d4fd805
@vlad-perevezentsev
Add simplify_iteration_space implementation to libtensor
c040713
@vlad-perevezentsev
Extend codespell ignore list for libtensor
14b466f
@vlad-perevezentsev
Add copy_and_cast kernels to libtensor
dcc421b
@vlad-perevezentsev
Add copy_usm_ndarray_into_usm_ndarray implementation
5a9c14c
@vlad-perevezentsev
Add pybind11 bindings for dpctl_ext.tensor._tensor_impl
4f63340
@vlad-perevezentsev
Add CMake build files for dpctl_ext
634579c
@vlad-perevezentsev
Add empty __init__ to dpctl_ext/
79d40f2
@vlad-perevezentsev
Enable _same_logical_tensors in _tensor_impl
7949c17
@vlad-perevezentsev
Add device_support_queries to enable default device types
29d6c02
@vlad-perevezentsev
Enable building and packaging of dpctl_ext
936e719
@vlad-perevezentsev
Use _tensor_impl from dpctl_ext.tensor in dpnp
cd85f1e
@vlad-perevezentsev
Move put() and take() to dpctl_ext/tensor
0c6780a
@vlad-perevezentsev
Use put/take from dpctl_ext.tensor in dpnp
87e5482
@vlad-perevezentsev
Move full() to dpctl_ext/tensor
b537f30
@vlad-perevezentsev
Use full and _full_usm_ndarray from dpctl_ext in dpnp
d50f263
@vlad-perevezentsev
Update .gitignore to ignore .so files in dpctl_ext
f189dc5
@vlad-perevezentsev
Move _zeros_usm_ndarray to dpctl_ext
f9a1817
@vlad-perevezentsev
Use _zeros_usm_ndarray from dpctl_ext in dpnp_fill.py
4b8505a
@vlad-perevezentsev
Move linear-sequence implementations to dpctl_ext/tensor
61106b2
@vlad-perevezentsev
Use _tensor_impl from dpctl_ext in dpnp_utils_fft.py
a030579
@vlad-perevezentsev
Move tril()/triu() to dpctl_ext/tensor
a1d6fa3
@vlad-perevezentsev
Use tril/triu/_tril from dpctl_ext.tensor in dpnp
f1d6e56
@vlad-perevezentsev
Disable pylint no-name-in-module for dpctl_ext
6680790
@vlad-perevezentsev
Add TODO comments
263b717
@vlad-perevezentsev
Use default_device_complex_type from dpctl_ext on test_array_api_info.py
4130c1b
@vlad-perevezentsev
Remove unused build_dpctl_ext function
17ca9ab
@vlad-perevezentsev
Apply remarks for CMake files
79cb2a4
@vlad-perevezentsev
Apply remarks for c++ files
4bf080e
@vlad-perevezentsev
Remove linear-sequence implementations
cfa6cd6
@vlad-perevezentsev
Use Python::Module for dpctl_ext static lib to avoid libpython depend…
c082224 
…ency
@vlad-perevezentsev
Merge move_tensor_impl_ext into move_tensor_impl_ext_part_2
9e7deb3
@vlad-perevezentsev
Merge include-dpctl-tensor into move_tensor_impl_ext_part_2
1a736f7
@vlad-perevezentsev
Merge move_tensor_impl_ext_part_2 into move_tensor_impl_copy
8bde614
@vlad-perevezentsev
Move ti.mask_positions() and ti._cumsum_1d()
c3bc8ba
@vlad-perevezentsev
Move ti._extract(), ti._place(), ti._nonzero()
69b36b2
@vlad-perevezentsev
Move place() to dpctl_ext/tensor and reuse it in dpnp
70a0fc6
@vlad-perevezentsev
Move extract() to dpctl_ext/tensor and reuse it in dpnp
afa5411
@vlad-perevezentsev
Move nonzero() to dpctl_ext/tensor and reuse it in dpnp
7feb4ee
@vlad-perevezentsev
Move put_along_axis to dpctl_ext/tensor and reuse it in dpnp
f63f2f0
@vlad-perevezentsev
Move take_along_axis() to dpctl_ext/tensor and reuse it in dpnp
6fecefe
@vlad-perevezentsev
Move ti._eye to() to dpctl_ext/tensor/libtensor
b60d095
@vlad-perevezentsev
Move eye() to dpctl_ext/tensor and reuse it in dpnp
a1eea4e
@vlad-perevezentsev vlad-perevezentsev self-assigned this Feb 19, 2026
@vlad-perevezentsev vlad-perevezentsev mentioned this pull request Feb 19, 2026
Open
@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2026 •
edited
Loading

Array API standard conformance tests for dpnp=0.20.0dev3=py313h509198e_74 ran successfully.
Passed: 1355
Failed: 2
Skipped: 16

@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2026 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vlad-perevezentsev vlad-perevezentsev marked this pull request as ready for review February 20, 2026 11:08
ndgrigorian
ndgrigorian previously approved these changes Mar 2, 2026
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from move_tensor_impl_copy to include-dpctl-tensor March 3, 2026 10:25
@vlad-perevezentsev vlad-perevezentsev dismissed ndgrigorian’s stale review March 3, 2026 10:25

The base branch was changed.

ndgrigorian
ndgrigorian previously approved these changes Mar 3, 2026
View reviewed changes
@vlad-perevezentsev vlad-perevezentsev merged commit 192bd93 into include-dpctl-tensor Mar 3, 2026
91 of 93 checks passed
@vlad-perevezentsev vlad-perevezentsev deleted the move_tensor_impl_accum_bool_ind_eye branch March 3, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

@antonwolfy antonwolfy Awaiting requested review from antonwolfy antonwolfy is a code owner

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vlad-perevezentsev @ndgrigorian