fix(grid): collapsed column group calcPixelWidth incorrectly constrained to minColumnWidth (#17042)#17064
Draft
fix(grid): collapsed column group calcPixelWidth incorrectly constrained to minColumnWidth (#17042)#17064
Conversation
…s with explicit child widths (#17042) Co-authored-by: ivanvpetrov <110455887+ivanvpetrov@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [17042] Investigate issue using bug-fixing-orchestrator agent
fix(grid): collapsed column group calcPixelWidth incorrectly constrained to minColumnWidth (#17042)
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a collapsible column group is collapsed and its visible child columns have explicit widths smaller than
minColumnWidth(136px), the header and cell virtual scrollers use mismatched widths — causing horizontal misalignment after scrolling.Root cause
PR #16636 added a
minColumnWidthfloor ingetConstrainedSizePx()targeting unsized columns. Column groups havewidthSetByUser = false(theirset width()is a no-op) so this condition also fired for them. With one visible collapsed child at 100px:group.calcPixelWidth = 136← incorrectly flooredcolumnA.calcPixelWidth = 100← correct explicit widthFix
Added
!this.columnGroupguard to the new condition ingetConstrainedSizePx(). Column group width is always the sum of visible children — it must never be independently floored tominColumnWidth.Changes
column.component.ts— One-line guard added togetConstrainedSizePx()grid-collapsible-columns.spec.ts— Regression test: collapsed groupcalcPixelWidthmust equal the sum of its visible children's widths, notminColumnWidthtest-utils/grid-samples.spec.ts—CollapsibleGroupFirstColumnWidthComponentfixture (collapsible first group, explicit child widths < 136px, standalone columns with explicit widths forcing a horizontal scrollbar)CHANGELOG.md— Bug fix entry under 21.2.0Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
accounts.google.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4858 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-5380339 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,1767742148619126290,4177245314570888366,262144 --disable-features=PaintHolding --variations-seed-version --trace-process-track-uuid=3190708989122997041(dns block)/home/REDACTED/.cache/puppeteer/chrome/linux-145.0.7632.46/chrome-linux64/chrome /home/REDACTED/.cache/puppeteer/chrome/linux-145.0.7632.46/chrome-linux64/chrome --user-data-dir=/tmp/karma-5380339 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox --disable-gpu --window-size=820,800 --js-flags=--expose-gc http://localhost:9876/?id=5380339 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4859 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-92561409 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,10303362430134108348,5035785990288150114,262144 --disable-features=PaintHolding --variations-seed-version --trace-process-track-uuid=3190708989122997041(dns block)clients2.google.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4858 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-5380339 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,1767742148619126290,4177245314570888366,262144 --disable-features=PaintHolding --variations-seed-version --trace-process-track-uuid=3190708989122997041(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4859 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-92561409 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,10303362430134108348,5035785990288150114,262144 --disable-features=PaintHolding --variations-seed-version --trace-process-track-uuid=3190708989122997041(dns block)/home/REDACTED/.cache/puppeteer/chrome/linux-145.0.7632.46/chrome-linux64/chrome /home/REDACTED/.cache/puppeteer/chrome/linux-145.0.7632.46/chrome-linux64/chrome --user-data-dir=/tmp/karma-5380339 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox --disable-gpu --window-size=820,800 --js-flags=--expose-gc http://localhost:9876/?id=5380339 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222(dns block)content-autofill.googleapis.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5588 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-2736915 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,3113948546176594774,5895901476528518885,262144 --disable-features=PaintHolding --variations-seed-version --trace-process-track-uuid=3190708989122997041 sources.ts es.ts(dns block)/home/REDACTED/.cache/puppeteer/chrome/linux-145.0.7632.46/chrome-linux64/chrome /home/REDACTED/.cache/puppeteer/chrome/linux-145.0.7632.46/chrome-linux64/chrome --user-data-dir=/tmp/karma-2736915 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox --disable-gpu --window-size=820,800 --js-flags=--expose-gc http://localhost:9876/?id=2736915 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5937 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-98524574 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,6781892557428214697,16982997161804983729,262144 --disable-features=PaintHolding --variations-seed-version --trace-process-track-uuid=3190708989122997041(dns block)redirector.gvt1.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4859 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-92561409 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,10303362430134108348,5035785990288150114,262144 --disable-features=PaintHolding --variations-seed-version --trace-process-track-uuid=3190708989122997041(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4858 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-5380339 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,1767742148619126290,4177245314570888366,262144 --disable-features=PaintHolding --variations-seed-version --trace-process-track-uuid=3190708989122997041(dns block)/home/REDACTED/.cache/puppeteer/chrome/linux-145.0.7632.46/chrome-linux64/chrome /home/REDACTED/.cache/puppeteer/chrome/linux-145.0.7632.46/chrome-linux64/chrome --user-data-dir=/tmp/karma-92561409 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox --disable-gpu --window-size=820,800 --js-flags=--expose-gc http://localhost:9876/?id=92561409 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222(dns block)www.google.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4858 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-5380339 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,1767742148619126290,4177245314570888366,262144 --disable-features=PaintHolding --variations-seed-version --trace-process-track-uuid=3190708989122997041(dns block)/home/REDACTED/.cache/puppeteer/chrome/linux-145.0.7632.46/chrome-linux64/chrome /home/REDACTED/.cache/puppeteer/chrome/linux-145.0.7632.46/chrome-linux64/chrome --user-data-dir=/tmp/karma-5380339 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox --disable-gpu --window-size=820,800 --js-flags=--expose-gc http://localhost:9876/?id=5380339 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4859 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-92561409 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,10303362430134108348,5035785990288150114,262144 --disable-features=PaintHolding --variations-seed-version --trace-process-track-uuid=3190708989122997041(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.