[Accessibility] Fix: turn File Input close into a button element #11327
Open
abrahammordev wants to merge 2 commits intoILIAS-eLearning:release_10from
Open
[Accessibility] Fix: turn File Input close into a button element #11327abrahammordev wants to merge 2 commits intoILIAS-eLearning:release_10from
abrahammordev wants to merge 2 commits intoILIAS-eLearning:release_10from
Conversation
thibsy
reviewed
Mar 24, 2026
Contributor
thibsy
left a comment
There was a problem hiding this comment.
Hi @abrahammordev,
Very sorry for your spent work, but I think this and all other issue in regards of glyph components rendered as an <a> tag or missing role="img" attribute are fixed and superseded by #11260.
I leave this open until the other PR is fixed and we could verify the linked mantis issue here is addressed as well.
Kind regards,
@thibsy (as UI coordinator)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File Input Close Button Accessibility Improvement
The close glyph used to remove selected files was implemented as an
<a>element. This is not semantically correct and may cause accessibility and usability issues, as it does not convey the proper button behavior to assistive technologies.This change replaces the with a proper
<button>HTML element, ensuring better semantics, accessibility, and consistency with expected UI patterns.Changes
Updated File Input component:
<a>element used as a close/remove control with a<button>elementUpdated
FileInputTest:<button>markupNote
These changes required updates to existing tests to align with the new markup structure.
Related