Fix #47085 Tag example contrast#11321
Open
marvimarv wants to merge 1 commit intoILIAS-eLearning:release_10from
Open
Fix #47085 Tag example contrast#11321marvimarv wants to merge 1 commit intoILIAS-eLearning:release_10from
marvimarv wants to merge 1 commit intoILIAS-eLearning:release_10from
Conversation
Set a darker fixed foreground color in the Button/Tag Kitchen Sink example so the red/green sample meets WCAG AA contrast for normal text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
components/ILIAS/UI/src/examples/Button/Tag/base.phpis changed.If approved, please pick this to release_11 and trunk.
https://mantis.ilias.de/view.php?id=47085
Test plan
goto.php/stys/21/ButtonTagTag/default/delossimple tagin "with fix colors" reaches at least4.5:1