Skip to content

Avoid redundant shSync in ExitCode by reusing exit code from Sh.postRun #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stalep wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid redundant shSync in ExitCode by reusing exit code from Sh.postRun #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion qDup-core/src/main/java/io/hyperfoil/tools/qdup/cmd/impl/ExitCode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
*/
public class ExitCode extends Cmd {

private static final String EXIT_CODE_KEY = "qdupExitCode";
static final String EXIT_CODE_KEY = "qdupExitCode";
private static final String DEFAULT_EXIT_CODE = "-1";

private String expected;
Expand Down
2 changes: 2 additions & 0 deletions qDup-core/src/main/java/io/hyperfoil/tools/qdup/cmd/impl/Sh.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,8 @@ public void postRun(String output,Context context){
context.abort(false);
} else if (context.getShell().isReady() && !context.isAborted()) {
context.setCwd(pwd);
// Store exit code for ExitCode command to find without a separate shSync
with(ExitCode.EXIT_CODE_KEY, response);
if(response.matches("\\d+")){
try {
context.getCommandTimer().getData().set("exit_code", Integer.parseInt(response));
Expand Down
Loading