plans: PR-F1 (Feign-not-an-exposer) + PR-G1 (cross_service_resolution flag)#27
Merged
Merged
Conversation
Implements the merged proposes (#25 #26) as per-PR plans following the PLAN-POST-TIER1B-FOLLOWUPS structure: scope, out-of-scope, background, failure modes, resolution with code anchors, tests table, manual evidence, definition of done, risk register, followups, references. PLAN-FEIGN-NOT-AN-EXPOSER: single PR (PR-F1), gates EXPOSES emission on route.kind != 'http_consumer', surfaces suppression count in GraphMeta. No schema bump (additive nullable column). PLAN-CROSS-SERVICE-RESOLUTION-FLAG: single PR (PR-G1), adds cross_service_resolution flag (auto | brownfield_only) to .lancedb-mcp.yml. Gates pass6_match_edges cross-service candidates on _is_brownfield_sourced helper. Ontology bump 7->8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two per-PR plans implementing the merged proposes:
plans/PLAN-FEIGN-NOT-AN-EXPOSER.md— implements #25build_ast_graph.py:1357to gate EXPOSES emission onroute.kind != "http_consumer"pass4_exposes_suppressed_feigncounter onGraphMeta(additive, nullable read)cross_service_smokefixtureplans/PLAN-CROSS-SERVICE-RESOLUTION-FLAG.md— implements #26_load_config_cross_service_resolutionreader ingraph_enrich.pymirroring_load_config_microservice_rootscross_service_resolutionfield onGraphTables_is_brownfield_sourcedhelper + gate in both HTTP and async loops ofpass6_match_edgesGraphMetaschema extended; ontology bump 7 → 8Sequencing
PR-F1 and PR-G1 are orthogonal (different passes — pass4 vs pass6) and can ship in either order. Recommend PR-F1 first as a clear bug fix; then PR-G1; then real-project test in
brownfield_onlymode.Combined target test count after both PRs: ~280 passed, 4 skipped (266 baseline + 6 + 8).
Out of scope across both plans
Status
Draft. After review, I'll draft per-PR Cursor task prompts using the
cursor-task-promptskill template.