Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Cursor task prompts — CALLS-NOISE-AND-RESOLUTION (PR-1 → PR-3)

Status: **active**. Plan:
[`plans/PLAN-CALLS-NOISE.md`](./PLAN-CALLS-NOISE.md). Propose:
[`propose/CALLS-NOISE-AND-RESOLUTION-PROPOSE.md`](../propose/CALLS-NOISE-AND-RESOLUTION-PROPOSE.md)
Status: **completed** (reference template). Plan:
[`plans/completed/PLAN-CALLS-NOISE.md`](./PLAN-CALLS-NOISE.md). Propose:
[`propose/completed/CALLS-NOISE-AND-RESOLUTION-PROPOSE.md`](../../propose/completed/CALLS-NOISE-AND-RESOLUTION-PROPOSE.md)
(tracks [#177](https://github.com/HumanBean17/java-codebase-rag/issues/177)).

One prompt per code PR. **Landing order:** PR-1 → PR-2 → PR-3. Do not start the next PR until the previous is merged to `master`.
Expand Down Expand Up @@ -398,6 +398,6 @@ rm -rf /tmp/calls-pr3 && .venv/bin/python build_ast_graph.py \

## After all PRs land

- Move `plans/PLAN-CALLS-NOISE.md` and this file to `plans/completed/`.
- Move `propose/CALLS-NOISE-AND-RESOLUTION-PROPOSE.md` to `propose/completed/`.
- Close [#177](https://github.com/HumanBean17/java-codebase-rag/issues/177).
- [x] Plan + prompts archived under `plans/completed/`.
- [x] Propose archived under `propose/completed/`.
- [ ] Close [#177](https://github.com/HumanBean17/java-codebase-rag/issues/177) if still open.
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
# Plan: CALLS-NOISE-AND-RESOLUTION

Status: **active** (propose rev5 under review on [#179](https://github.com/HumanBean17/java-codebase-rag/pull/179)).
Status: **completed** — PR-1 → PR-3 landed on `master` (ontology 15).
Source propose:
[`propose/CALLS-NOISE-AND-RESOLUTION-PROPOSE.md`](../propose/CALLS-NOISE-AND-RESOLUTION-PROPOSE.md)
(tracks [#177](https://github.com/HumanBean17/java-codebase-rag/issues/177); merged on `master` via [#178](https://github.com/HumanBean17/java-codebase-rag/pull/178)).
[`propose/completed/CALLS-NOISE-AND-RESOLUTION-PROPOSE.md`](../../propose/completed/CALLS-NOISE-AND-RESOLUTION-PROPOSE.md)
(tracks [#177](https://github.com/HumanBean17/java-codebase-rag/issues/177)).

Depends on: **SCHEMA-V2 landed** (`EDGE_SCHEMA`, MCP v2 tools). Complements
[`propose/AGENT-SKILLS-AND-COMMANDS-PROPOSE.md`](../propose/AGENT-SKILLS-AND-COMMANDS-PROPOSE.md)
`/mini-map` for accessor noise (Decision 39) — not a blocker.

**Cursor prompts:** [`plans/CURSOR-PROMPTS-CALLS-NOISE.md`](./CURSOR-PROMPTS-CALLS-NOISE.md)
(per-PR handoffs). Do **not** open PR-1 code until that file is on `master`.
**Cursor prompts:** [`plans/completed/CURSOR-PROMPTS-CALLS-NOISE.md`](./CURSOR-PROMPTS-CALLS-NOISE.md)
(per-PR handoffs; reference template).

## Fixture anchors (pinned — do not use fictional types)

Expand Down Expand Up @@ -255,8 +255,8 @@ rm -rf /tmp/calls-pr3 && .venv/bin/python build_ast_graph.py \

## Definition of done (whole effort)

- [ ] Propose merged; moved to `propose/completed/` when PR-3 lands.
- [ ] All three PRs merged to `master` in order.
- [ ] `CURSOR-PROMPTS-CALLS-NOISE.md` archived under `plans/completed/` with final sentinels.
- [ ] README ontology 15 + re-index callout accurate.
- [x] Propose merged; moved to `propose/completed/` when PR-3 lands.
- [x] All three PRs merged to `master` in order.
- [x] `CURSOR-PROMPTS-CALLS-NOISE.md` archived under `plans/completed/` with final sentinels.
- [x] README ontology 15 + re-index callout accurate.
- [ ] `/mini-map` skill doc mentions `edge_filter` when PR-2 ships (optional doc-only follow-up on agent-skills branch).
10 changes: 5 additions & 5 deletions propose/completed/CALLS-NOISE-AND-RESOLUTION-PROPOSE.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
**Author**: Dmitriy Teriaev + Perplexity Computer
**Date**: 2026-05-18
**Tracks**: [#177](https://github.com/HumanBean17/java-codebase-rag/issues/177)
**Plan**: [`plans/PLAN-CALLS-NOISE.md`](../plans/PLAN-CALLS-NOISE.md) (per-PR sentinels, tests, landing order)
**Prompts**: [`plans/CURSOR-PROMPTS-CALLS-NOISE.md`](../plans/CURSOR-PROMPTS-CALLS-NOISE.md) (PR-1 → PR-3 handoffs)
**Plan**: [`plans/completed/PLAN-CALLS-NOISE.md`](../plans/completed/PLAN-CALLS-NOISE.md) (per-PR sentinels, tests, landing order)
**Prompts**: [`plans/completed/CURSOR-PROMPTS-CALLS-NOISE.md`](../plans/completed/CURSOR-PROMPTS-CALLS-NOISE.md) (PR-1 → PR-3 handoffs)

## TL;DR

Expand All @@ -25,7 +25,7 @@
### Fixture anchors (pinned for tests and HV rows)

Do **not** use fictional types (`OrderService`, `MyRepository`) in committed test names or
perf scenarios. See [`plans/PLAN-CALLS-NOISE.md`](../plans/PLAN-CALLS-NOISE.md) § Fixture anchors.
perf scenarios. See [`plans/completed/PLAN-CALLS-NOISE.md`](../plans/completed/PLAN-CALLS-NOISE.md) § Fixture anchors.

| Anchor | FQN / path | Measured on fresh `bank-chat-system` (2026-05-19) |
| --- | --- | --- |
Expand Down Expand Up @@ -622,11 +622,11 @@ ALTER NODE TABLE GraphMeta ADD COLUMN pass3_unresolved_chained INT64;
- **Test name:** `test_neighbors_calls_edge_filter_pushdown_in_cypher` unified; perf test renamed to `..._client_message_processor` (heavy-gated).
- **PR-2:** CLI deferred to PR-3; PR-1 README notes row-count delta from dedup.
- **PR-3:** interleave tie-break + `dedup_calls` canonical line locked in plan.
- **Cursor prompts:** [`plans/CURSOR-PROMPTS-CALLS-NOISE.md`](../plans/CURSOR-PROMPTS-CALLS-NOISE.md) added — merge gate for PR-1 **code** is satisfied once [#179](https://github.com/HumanBean17/java-codebase-rag/pull/179) lands on `master`.
- **Cursor prompts:** [`plans/completed/CURSOR-PROMPTS-CALLS-NOISE.md`](../plans/completed/CURSOR-PROMPTS-CALLS-NOISE.md) added — merge gate for PR-1 **code** is satisfied once [#179](https://github.com/HumanBean17/java-codebase-rag/pull/179) lands on `master`.

**Revision 4 (2026-05-19, post-critical-review implementation contract)** — propose patches before code PRs:

- **Status → under review.** Plan file added: [`plans/PLAN-CALLS-NOISE.md`](../plans/PLAN-CALLS-NOISE.md).
- **Status → under review.** Plan file added: [`plans/completed/PLAN-CALLS-NOISE.md`](../plans/completed/PLAN-CALLS-NOISE.md).
- **ORDER BY contract (Decision 36, §3.4.1, HV38):** PR-2 locks `ORDER BY e.call_site_line, e.call_site_byte` on all CALLS `neighbors_v2` paths.
- **`edge_filter` pushdown (Decision 37, §3.4.1):** Cypher `WHERE` predicates before `offset`/`limit`; no pre-filter `LIMIT`.
- **`exclude_external` stance (Decision 38, §3.4.2):** not added to `neighbors_v2`; HV37 corrected; AGENT-GUIDE requirement in PR-2.
Expand Down
Loading