plan: schema-v2 and hints-v3 execution plans#155
Conversation
Execution-ready PR breakdown per PROPOSES-ORDER: EDGE_SCHEMA v14, HTTP/ASYNC caller-side flips, Producer node, and PR-D hints v3 handoffs. Co-authored-by: Cursor <cursoragent@cursor.com>
HumanBean17
left a comment
There was a problem hiding this comment.
Review summary
Verdict: approve with small doc fixes (before or immediately after merge).
This is the right artefact at the right time — satisfies Decision 29 / docs/PROPOSES-ORDER.md Phase 2 so SCHEMA-V2 PR-A can start. Structure matches completed PLAN-* / CURSOR-PROMPTS-* pairs; sequencing (A→B→C→D), sentinel greps, and verbatim test names are strong.
Recommended fixes on this PR (or tiny follow-up)
-
typical_traversalsshape conflict —propose/SCHEMA-V2-PROPOSE.mdAppendix A usestuple[str, ...];propose/HINTS-V3-PROPOSE.md§3.5 and these plans usedict[str, str](role keys). PR-A should lock one line inPLAN-SCHEMA-V2.md+CURSOR-PROMPTS-SCHEMA-V2.md, e.g. PR-A contract: role-keyeddict[str, str]per HINTS-V3 §3.5; SCHEMA Appendix A tuple examples are illustrative only. -
member_onlyvsDECLARES_PRODUCER— HINTS §3.4 setsmember_onlyonDECLARES_PRODUCER, but PR-A only ships 10 edges. Clarify PR-A sets flags onDECLARES_CLIENT,EXPOSES,OVERRIDES,CALLSonly; PR-C addsDECLARES_PRODUCERwhen the edge lands. -
docs/PROPOSES-ORDER.md— Phase 2 still says plans “[not started]”; update after merge so the sequencing doc stays authoritative. -
propose/HINTS-V3-PROPOSE.md— stillStatus: draftonmasterthough #154 merged; small chore PR before PR-D lock gate.
Non-blocking (first code PR is fine)
- Add
@tests/test_mcp_v2_compose.pyto PR-B attach list (plan mentions it; prompt does not). - PR-C file-by-file should list
pr_analysis.py(implementation step table already does) for async two-hop after PR-B’s HTTP leg. - Stale
impact_analysisline anchor (~1335 vs ~1133 today). - Consider making
test_hints_neighbors_v2_empty_post_flip_method_http_callsrequired once post-flip fixtures exist.
Pre-implementation notes (code PRs)
- PR-A is not docs-only (workflow + generator) — full pytest will run; expected.
- v14 + pre-flip endpoints until B/C complete — README callout is critical.
- Freeze
BROWNFIELD_RESOLVER_STRATEGY_SETmembers in PR-A body (same discipline as HTTP_CALLS grep).
Merge when the typical_traversals / member_only clarifications are in (here or immediate follow-up). Then SCHEMA PR-A can branch off master.
Clarify role-keyed typical_traversals vs SCHEMA appendix tuples, split member_only across PR-A/PR-C, update PROPOSES-ORDER phase 2, and align prompts with pr_analysis and compose test coverage. Co-authored-by: Cursor <cursoragent@cursor.com>
Align propose, plan, and PROPOSES-ORDER headers with locked design and active code rollout (PR-A–D); HINTS-V3 code remains SCHEMA-V2 PR-D. Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
plans/PLAN-SCHEMA-V2.mdandplans/CURSOR-PROMPTS-SCHEMA-V2.mdfor PR-A/B/C (EDGE_SCHEMA, ontology v14, HTTP_CALLS Client→Route, Producer + ASYNC_CALLS flip).plans/PLAN-HINTS-V3.mdandplans/CURSOR-PROMPTS-HINTS-V3.mdfor PR-D (EDGE_SCHEMA-driven emptyneighborshints).docs/PROPOSES-ORDER.mdand SCHEMA-V2 Decision 29.Test plan
master).Made with Cursor