feat: filter frame counters + tool descriptions (PR-FRAME-3)#133
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Land the 3-PR migration docs under propose/completed/ and plans/completed/; point mcp_v2 revisit trigger at the new path. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Implements
plans/PLAN-MCP-FRAME.mdPR-FRAME-3: process-local fail-loud counters (mcp_v2.py), refreshed MCP tool descriptions (server.py), agent guide strict-frame + identifier fallback (docs/AGENT-GUIDE.md), and four counter tests (tests/test_mcp_v2.py).Related:
propose/MCP-FILTER-FRAME-PROPOSE.md(revisit trigger §3.4.6, identifier fallback §3.4.7).Changes
_fail_loud_counts/_fail_loud_lock,_log_fail_loud(category),filter_frame_counters()inmcp_v2.py; wired on filterValidationError, applicability, and wildcard paths insearch_v2,find_v2,neighbors_v2.description=strings updated inserver.py.docs/AGENT-GUIDE.md: strict frame contract, identifier-resolution pattern (search+describeper candidate untilresolve), correctedneighbors.filtersemantics.Tests
Manual evidence
With an initialized Kuzu graph (same as MCP), fail-loud events increment counters:
Without
graph=,find_v2may fail on DB open before filter validation; use MCP host context or tests.Ontology / reindex
None.
Made with Cursor