feat: filter frame edge decisions (PR-FRAME-2)#132
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Implements PR-FRAME-2 from
plans/PLAN-MCP-FILTER-FRAME.md(frame-edge decisions §3.4.1–§3.4.6 in code and tests; §3.4.7 deferred to PR-FRAME-3 per plan). Rationale:propose/MCP-FILTER-FRAME-PROPOSE.mdsection 3.4.Changes
_validate_no_wildcardsonfqn_prefix,path_prefix,target_path_prefix; wired intofind_v2,search_v2, andneighbors_v2after applicability checks, before querying. Errors hint atsearch(query=...).describe(fqn=...):describe_v2and MCPdescribetool accept optionalfqnfor exact Symbol FQN lookup;idwins when both set; collision returns first match with disambiguationmessage.mcp_v2.py: strict frame contract and N=3 / 6-month revisit trigger (propose section 3.4.6).tests/test_mcp_v2.pyper plan (multi-value OR, cross-field AND,exclude_roles, empty filter, wildcards, describe-by-fqn).Out of scope (not in this PR)
PR-FRAME-3 items: tool-description refresh for search/find/neighbors, local fail-loud counters,
docs/AGENT-GUIDE.md, §3.4.7 identifier-resolution text in tool descriptions.Validation
.venv/bin/ruff check .PATH="<repo>/.venv/bin:$PATH" .venv/bin/python -m pytest tests -q(426 passed, 10 skipped)Files
mcp_v2.py,server.py,tests/test_mcp_v2.pyonly (vsmaster).Depends on / stacks with PR-FRAME-1 vocabulary work already on this branch where applicable.
Made with Cursor