fix neighbors_v2 edge-type filter for Kuzu (closes #119)#121
Merged
Conversation
- Replace label(e) IN $list with OR of scalar label(e) = $p (Kuzu 0.11.x). - Avoid typed union rel patterns here: RETURN columns differ across rel types. - Add regression test for strict-subset edge_types; adjust FakeGraph stub. - Document Kuzu Cypher pitfalls in AGENTS.md, kuzu_queries.py, tests/README. Fixes #119. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes incorrect
neighbors_v2results whenedge_typesis a strict subset of a node’s incident edge labels. Kuzu 0.11.x can ignorelabel(e) IN $listinWHERE.Approach
label(e) IN $edge_typeswith OR of scalar equalities (label(e) = $l0 OR …) using bound parameters after Pydantic allowlisting.-[e:CALLS|HTTP_CALLS]-here:RETURNreads columns that do not exist on every rel type in the union, which triggers Kuzu binder errors.Tests
tests/test_mcp_v2.py -k neighbor(includes new strict-subset regression test).Docs
AGENTS.md,kuzu_queries.pymodule docstring, andtests/README.md.Closes #119
Made with Cursor