Skip to content

Fixing Broken LRC Update #87

Merged
Amazing-Stardom merged 3 commits into
mainfrom
fix/failing-update
May 25, 2026
Merged

Fixing Broken LRC Update #87
Amazing-Stardom merged 3 commits into
mainfrom
fix/failing-update

Conversation

@Amazing-Stardom
Copy link
Copy Markdown
Contributor

In this discussion #74 (comment) developer had issues with updating git-lrc.

PS C:\Users\tejas> git-lrc update
Current version: v0.3.7
Checking for updates...
Latest version:  v0.3.8

⬆ Update available: v0.3.7 → v0.3.8
Downloading update artifact...
Error: failed to stage update: failed to download update binary: failed to stream self-update body: context deadline exceeded (Client.Timeout or context cancellation while reading body)

The root cause of the issues was there was a context timeout of the whole application download.

Fixed it by removing the context deadline.

Adding ETA and progress of the downloading application.

LiveReview Pre-Commit Check: ran (iter:1, coverage:0%)
LiveReview Pre-Commit Check: ran (iter:3, coverage:54%)
LiveReview Pre-Commit Check: ran (iter:1, coverage:0%)
@lovestaco
Copy link
Copy Markdown
Contributor

For manifest also you removed time out, is that required?

Only for binary download is enough right?

@shrsv
Copy link
Copy Markdown
Contributor

shrsv commented May 25, 2026

For manifest also you removed time out, is that required?

Only for binary download is enough right?

I think that's OK, none of the actions - we need timeout

@Amazing-Stardom Amazing-Stardom merged commit c8ad044 into main May 25, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants