Skip to content

Upgrade WGPU and Linebender dependencies#4154

Open
Keavon wants to merge 4 commits into
masterfrom
upgrade-linebender-deps
Open

Upgrade WGPU and Linebender dependencies#4154
Keavon wants to merge 4 commits into
masterfrom
upgrade-linebender-deps

Conversation

@Keavon
Copy link
Copy Markdown
Member

@Keavon Keavon commented May 16, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 issues found across 19 files

Confidence score: 4/5

  • This PR is likely safe to merge with minimal risk: the reported issues are low-to-medium severity (5/10, 4/10, 3/10) and mostly affect rendering state handling and logging behavior rather than core correctness.
  • Most significant functional risk is in desktop/src/render/state.rs: treating Suboptimal the same as Success can skip needed surface reconfiguration, which may cause degraded rendering behavior after swapchain changes.
  • Also in desktop/src/render/state.rs, treating Occluded as an error can generate noisy logs while windows are minimized/hidden; this is user-visible noise but not typically a hard failure.
  • Pay close attention to desktop/src/render/state.rs and Cargo.toml - fix Suboptimal/Occluded handling to avoid render-state regressions and align PR title capitalization with wgpu.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="Cargo.toml">

<violation number="1" location="Cargo.toml:123">
P3: Custom agent: **PR title enforcement**

PR title uses 'WGPU' but the crate name is `wgpu` (lowercase). The title should match the exact crate/library name capitalization.</violation>
</file>

<file name="desktop/src/render/state.rs">

<violation number="1" location="desktop/src/render/state.rs:266">
P2: `Suboptimal` is currently treated exactly like `Success`, so the surface is never reconfigured when it becomes suboptimal.</violation>

<violation number="2" location="desktop/src/render/state.rs:270">
P2: `Occluded` should be treated as a skipped frame, not a render error. Returning an error here will produce noisy error logs while the window is minimized/hidden.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Re-trigger cubic

Comment thread desktop/src/render/state.rs Outdated
Comment thread desktop/src/render/state.rs Outdated
Comment thread Cargo.toml
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates major dependencies including wgpu to v29.0, wasm-bindgen to v0.2.121, and several Linebender ecosystem crates. These updates require various API adjustments across the codebase, such as wrapping bind group layouts in Option, handling the new CurrentSurfaceTexture enum, and updating canvas method calls to use integer coordinates. Review feedback highlights that the transition to the new RenderError enum in the desktop renderer has inadvertently removed explicit handling for GPU OutOfMemory errors, which previously ensured a graceful application exit.

Comment thread desktop/src/render/state.rs Outdated
Comment thread desktop/src/app.rs
Comment thread desktop/src/render/state.rs
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="desktop/src/render/state.rs">

<violation number="1" location="desktop/src/render/state.rs:269">
P1: Reconfiguring the surface inside the `Suboptimal` arm can panic because the acquired `SurfaceTexture` is still alive.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Re-trigger cubic

Comment thread desktop/src/render/state.rs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant