This repository was archived by the owner on Apr 15, 2026. It is now read-only.
Refine CLI defaults and agent auth handling#31
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
headjack | bb7bed0 | Commit Preview URL Branch Preview URL |
Jan 02 2026, 10:49 PM |
jmgilman
added a commit
that referenced
this pull request
Jan 3, 2026
Current behavior: CLI commands used hardcoded paths and repetitive switch statements for agent authentication, with scattered default value resolution logic. New behavior: Centralized default resolution with helper functions, unified agent auth handling through a specification map, and consistent data directory path management. Closes: #31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
--agentflag to be specified without an explicit value and validate agent names independently of a loaded config.Description
DefaultBaseImageand updated Viper defaults and tests to use it instead of an unexported symbol.defaultDataDirandresolveBaseImagehelpers and wired them intoinitManager,logsandrecreateflows so defaults come from a single place.agentAuthSpecsmap and unifiedinjectAuthTokenlogic, and enabled--agentto accept no option value viaNoOptDefValwith sentinel handling.config.IsValidAgent/config.ValidAgentNames) and updated call sites accordingly.Testing
gofmtto ensure style consistency and applied the changes to source and tests.DefaultBaseImagewhere applicable but no automatedgo testrun in this rollout.Codex Task