feat: add snackbar notification upon channels query pagination failure#3179
Open
MartinCupela wants to merge 1 commit intomasterfrom
Open
feat: add snackbar notification upon channels query pagination failure#3179MartinCupela wants to merge 1 commit intomasterfrom
MartinCupela wants to merge 1 commit intomasterfrom
Conversation
|
Size Change: +1.67 kB (+0.25%) Total Size: 680 kB 📦 View Changed
ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
While testing the implementation of GetStream/stream-chat-js#1737, I found out, that we do not notify in the UI, that channels pagination request failed. This is easy to induce, if predefined_filter that is sent in the query request does not exist server-side. The resulting chat UI by default is empty and so we need to show, why the UI is empty.