Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: cached reaction details #3173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: cached reaction details #3173
Changes from all commits
d63d7cfFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check failure on line 28 in src/components/Reactions/hooks/ReactionPaginator.ts
src/components/Reactions/__tests__/MessageReactionsDetail.test.tsx > MessageReactionsDetail > should show extended reaction list when add emoji button is clicked
Check failure on line 41 in src/components/Reactions/hooks/useReactionPaginator.ts
src/components/Reactions/__tests__/MessageReactionsDetail.test.tsx > MessageReactionsDetail > should provide contextual accessible name for current-user remove button
Check failure on line 41 in src/components/Reactions/hooks/useReactionPaginator.ts
src/components/Reactions/__tests__/MessageReactionsDetail.test.tsx > MessageReactionsDetail > should render add emoji button in the reaction type list
Check failure on line 41 in src/components/Reactions/hooks/useReactionPaginator.ts
src/components/Reactions/__tests__/MessageReactionsDetail.test.tsx > MessageReactionsDetail > should always display reaction count for each reaction type
Check failure on line 41 in src/components/Reactions/hooks/useReactionPaginator.ts
src/components/Reactions/__tests__/MessageReactionsDetail.test.tsx > MessageReactionsDetail > emits typed notification when fetching reactions fails
Check failure on line 41 in src/components/Reactions/hooks/useReactionPaginator.ts
src/components/Reactions/__tests__/MessageReactionsDetail.test.tsx > MessageReactionsDetail > should use custom reaction details comparator if provided
Check failure on line 41 in src/components/Reactions/hooks/useReactionPaginator.ts
src/components/Reactions/__tests__/MessageReactionsDetail.test.tsx > MessageReactionsDetail > should display total reaction count
Check failure on line 41 in src/components/Reactions/hooks/useReactionPaginator.ts
src/components/Reactions/__tests__/MessageReactionsDetail.test.tsx > MessageReactionsDetail > should switch to display users of different reaction type
Check failure on line 41 in src/components/Reactions/hooks/useReactionPaginator.ts
src/components/Reactions/__tests__/MessageReactionsDetail.test.tsx > MessageReactionsDetail > should display a list of reacted users
Check failure on line 41 in src/components/Reactions/hooks/useReactionPaginator.ts
src/components/Reactions/__tests__/MessageReactionsDetail.test.tsx > MessageReactionsDetail > should render the reactions detail panel
Uh oh!
There was an error while loading. Please reload this page.