Skip to content

feat: Android Chat, Video and Feeds skills#8

Merged
gpunto merged 10 commits into
mainfrom
android-chat-skill
May 15, 2026
Merged

feat: Android Chat, Video and Feeds skills#8
gpunto merged 10 commits into
mainfrom
android-chat-skill

Conversation

@gpunto
Copy link
Copy Markdown
Contributor

@gpunto gpunto commented May 6, 2026

Adding Android skills mirroring the structure of Swift ones

@gpunto gpunto force-pushed the android-chat-skill branch 3 times, most recently from 7d5d248 to 2c35591 Compare May 6, 2026 10:45
@gpunto gpunto marked this pull request as ready for review May 6, 2026 13:11
@gpunto gpunto requested a review from a team May 6, 2026 13:11
Copy link
Copy Markdown
Contributor

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add one for xml components as well?

@gpunto gpunto force-pushed the android-chat-skill branch from 2c35591 to f9673be Compare May 7, 2026 15:29
andremion

This comment was marked as outdated.

Comment thread skills/stream-android/references/CHAT-COMPOSE-blueprints.md Outdated
Comment thread skills/stream-android/references/CHAT-COMPOSE-blueprints.md Outdated
Comment thread skills/stream-android/references/VIDEO-COMPOSE.md Outdated
Comment thread skills/stream-android/references/FEEDS-COMPOSE-blueprints.md Outdated
Comment thread skills/stream-android/SKILL.md Outdated
Comment thread README.md
@andremion
Copy link
Copy Markdown

A few suggestions. Not blockers, just ideas to improve the Kotlin code the agent writes:

  1. Add a short Kotlin-style section in sdk.md. The skills generate a lot of Kotlin, but never explain how to write it. Things to cover:

    • properties instead of getter functions (val foo: Foo get() = …)
    • named arguments for boolean flags
    • when instead of long if/else if chains
    • expression bodies for one-line functions
    • null-safety with ?. and ?: (use !! only when the value is guaranteed not to be null)
    • member references when readable (Channel::cid instead of { it.cid })

    About 15 lines, but without it, the agent often writes Java-style Kotlin in ViewModels and helpers.

  2. Add a single line to RULES.md: do not use // region / // endregion comments. The agent tends to add them in long files.

  3. Add a visibility rule to RULES.md: "Default to private or internal on new classes, functions, and properties. Use public only when something outside the file needs to access it." Without this, the agent makes everything public.

  4. The "Blueprints are mandatory on every turn" rule already says to re-read the blueprint section. For follow-up edits, one more step would help: before changing an existing screen, search the project for callers and observers. Useful when the user asks for a small change to a file that the agent did not open in this session.

@gpunto
Copy link
Copy Markdown
Contributor Author

gpunto commented May 13, 2026

A few suggestions. Not blockers, just ideas to improve the Kotlin code the agent writes:

Thanks for the suggestions! I'm going to check point 4 in particular. For the other ones, I think we should avoid giving broad style suggestions from a product-specific skill. They might conflict with the user's codebase style and their agents customization.

@gpunto gpunto requested review from myandrienko and vaneenige May 15, 2026 10:40
@gpunto gpunto merged commit 242a34a into main May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants