writeChartFile: [Song] / [SyncTrack] / [Events] / unrecognized sections#101
Open
elicwhite wants to merge 3 commits into
Open
writeChartFile: [Song] / [SyncTrack] / [Events] / unrecognized sections#101elicwhite wants to merge 3 commits into
elicwhite wants to merge 3 commits into
Conversation
This was referenced Apr 20, 2026
elicwhite
force-pushed
the
chart-writer-core
branch
from
44124f3 to
0fd5908
Compare
elicwhite
force-pushed
the
chart-writer-core
branch
2 times, most recently
from
82825de to
7215450
Compare
This was referenced Apr 20, 2026
elicwhite
force-pushed
the
chart-writer-core
branch
3 times, most recently
from
c0ba5d1 to
b8bec0b
Compare
2 tasks
elicwhite
force-pushed
the
chart-writer-core
branch
6 times, most recently
from
b8df59e to
2c17a17
Compare
Builds a minimal valid ParsedChart from scratch: default 480 resolution, 120 BPM at tick 0, 4/4 time signature at tick 0, empty tracks/sections/ metadata/vocal parts/unrecognized events. chartBytes defaults to an empty Uint8Array (no source bytes), format defaults to 'chart', iniChartModifiers to the library defaults. Options let callers override resolution, bpm, timeSignature, and format. Useful for programmatic chart generation (e.g. downstream code that builds charts up from scratch rather than parsing source bytes).
Serializes IniMetadata (Partial<typeof defaultMetadata> + extraIniFields) back to song.ini text with: - [song] header - Known fields emitted in the canonical defaultMetadata order - Undefined values skipped - Booleans as True/False (Clone Hero convention) - extraIniFields appended in insertion order - CRLF line endings Derives its field order from Object.keys(defaultMetadata) rather than hardcoding a separate FIELD_ORDER list, so new fields added to defaultMetadata automatically participate in writing. Tests exercise writeIniFile only via round-trip through parseChartAndIni, per reviewer feedback: build a metadata object, write it, re-parse, and assert on parsedChart.metadata. No assertions about the serialized ini text itself (CRLF, field order, True/False formatting, quoting) — those are implementation details.
…emission Port of the non-instrument-track half of the chart writer into scan-chart: - [Song] emits the subset of metadata the chart body supports (Name, Artist, Charter, Album, Genre, Year, Resolution, Offset, PreviewStart, Difficulty). Other fields live exclusively in song.ini. - [SyncTrack] emits tempos as `B millibeats` and time signatures as `TS numerator [denominator-exponent]`, sorted by tick with TS before B at the same tick. - [Events] emits section markers (wrapped as [section name] to survive the parser's greedy trailing-\] regex), end events, unrecognized global events (with bracket-stripping when source is .mid so round-trip to .chart emits naked text), and vocal phrase_start/phrase_end/lyric events from the normalized vocalTracks.parts.vocals. - Unrecognized chart sections are re-emitted verbatim. Instrument tracks ([ExpertSingle] etc.) land in a follow-up PR.
elicwhite
force-pushed
the
chart-writer-core
branch
from
2c17a17 to
78bd890
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Adds `.chart` file serialization (non-instrument half). Follow-up PR handles instrument track sections.
```ts
export function writeChartFile(chart: ParsedChart): string
```
Sections emitted
CRLF line endings throughout. All output round-trips cleanly through `parseChartAndIni`.
Depends on
PRs #97 + #98 + #99 + #100 — stacked above.