[Fixes #14242] Migrate groups endpoint to DRF#14270
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces API filters, serializers, and viewsets for Group, GroupProfile, and GroupCategory models, alongside updated test cases and routing. The code review feedback highlights a correctness bug in GroupCategorySerializer.get_member_count where group profile IDs are incorrectly compared to category IDs. Additionally, the feedback recommends defensively handling missing request contexts in serializers and missing self.request attributes in viewsets to prevent potential KeyError and AttributeError exceptions during schema generation or background tasks.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #14270 +/- ##
==========================================
+ Coverage 74.92% 74.96% +0.03%
==========================================
Files 975 977 +2
Lines 59902 60067 +165
Branches 8157 8171 +14
==========================================
+ Hits 44884 45029 +145
- Misses 13194 13205 +11
- Partials 1824 1833 +9 🚀 New features to boost your workflow:
|
Fixes #14242
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.