Skip to content

[Fixes #14242] Migrate groups endpoint to DRF#14270

Draft
nrjadkry wants to merge 2 commits into
masterfrom
ISSUE_14242
Draft

[Fixes #14242] Migrate groups endpoint to DRF#14270
nrjadkry wants to merge 2 commits into
masterfrom
ISSUE_14242

Conversation

@nrjadkry
Copy link
Copy Markdown
Contributor

@nrjadkry nrjadkry commented May 27, 2026

Fixes #14242

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label May 27, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces API filters, serializers, and viewsets for Group, GroupProfile, and GroupCategory models, alongside updated test cases and routing. The code review feedback highlights a correctness bug in GroupCategorySerializer.get_member_count where group profile IDs are incorrectly compared to category IDs. Additionally, the feedback recommends defensively handling missing request contexts in serializers and missing self.request attributes in viewsets to prevent potential KeyError and AttributeError exceptions during schema generation or background tasks.

Comment thread geonode/api/serializers.py
Comment thread geonode/api/serializers.py
Comment thread geonode/api/serializers.py
Comment thread geonode/api/views.py
Comment thread geonode/api/views.py
Comment thread geonode/api/views.py
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

❌ Patch coverage is 90.00000% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.96%. Comparing base (91c4ec5) to head (cfe7de4).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14270      +/-   ##
==========================================
+ Coverage   74.92%   74.96%   +0.03%     
==========================================
  Files         975      977       +2     
  Lines       59902    60067     +165     
  Branches     8157     8171      +14     
==========================================
+ Hits        44884    45029     +145     
- Misses      13194    13205      +11     
- Partials     1824     1833       +9     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nrjadkry nrjadkry marked this pull request as draft May 29, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate groups endpoint to DRF

1 participant