Skip to content

upgrade black dependency#14268

Open
mattiagiupponi wants to merge 2 commits into
masterfrom
black_deps
Open

upgrade black dependency#14268
mattiagiupponi wants to merge 2 commits into
masterfrom
black_deps

Conversation

@mattiagiupponi
Copy link
Copy Markdown
Contributor

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@mattiagiupponi mattiagiupponi requested a review from giohappy May 26, 2026 10:30
@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label May 26, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the version of the black dependency in pyproject.toml for both main and development dependencies. However, the specified version 26.3.1 is invalid because black uses calendar versioning (YY.M.B), making this a non-existent future release that will cause installation failures. It is recommended to use a valid, currently published version such as 24.10.0 instead.

Comment thread pyproject.toml
"requests-toolbelt==1.0.0",
"flake8==7.3.0",
"black==24.4.2",
"black==26.3.1",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The version 26.3.1 for black appears to be invalid or non-existent. Since black uses calendar versioning (YY.M.B), 26.3.1 would represent a release from March 2026. Please use a valid, currently published version of black (such as 24.10.0) to avoid installation errors.

Suggested change
"black==26.3.1",
"black==24.10.0",

Comment thread pyproject.toml
"pytest==8.4.2",
"flake8==7.3.0",
"black==24.4.2",
"black==26.3.1",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The version 26.3.1 for black appears to be invalid or non-existent. Since black uses calendar versioning (YY.M.B), 26.3.1 would represent a release from March 2026. Please use a valid, currently published version of black (such as 24.10.0) to avoid installation errors.

Suggested change
"black==26.3.1",
"black==24.10.0",

@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

❌ Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.92%. Comparing base (91c4ec5) to head (bc36ff7).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #14268   +/-   ##
=======================================
  Coverage   74.92%   74.92%           
=======================================
  Files         975      975           
  Lines       59902    59902           
  Branches     8157     8157           
=======================================
  Hits        44884    44884           
  Misses      13194    13194           
  Partials     1824     1824           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant