Skip to content

GeoNode 4.4.x does not build due to dependecy issue#14017

Open
mattiagiupponi wants to merge 2 commits into4.4.xfrom
ISSUE_14016
Open

GeoNode 4.4.x does not build due to dependecy issue#14017
mattiagiupponi wants to merge 2 commits into4.4.xfrom
ISSUE_14016

Conversation

@mattiagiupponi
Copy link
Contributor

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@mattiagiupponi mattiagiupponi requested a review from giohappy March 2, 2026 15:12
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Mar 2, 2026
@mattiagiupponi mattiagiupponi linked an issue Mar 2, 2026 that may be closed by this pull request
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a build failure in GeoNode 4.4.x by adding an upper bound to the setuptools dependency. This ensures compatibility and stabilizes the build process for the specified GeoNode version.

Highlights

  • Dependency Resolution: This PR addresses a build issue in GeoNode 4.4.x caused by an unconstrained setuptools dependency.
  • Version Constraint: The setuptools dependency is now constrained to versions greater than or equal to 59 and less than or equal to 63 (setuptools>=59,<=63).
  • File Modifications: The changes were applied to requirements.txt and setup.cfg to enforce the version constraint.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • requirements.txt
    • Constrained setuptools version to be between 59 and 63.
  • setup.cfg
    • Constrained setuptools version to be between 59 and 63.
Activity
  • The PR modifies requirements.txt and setup.cfg to limit the setuptools version.
  • The changes ensure that the GeoNode 4.4.x build process is stable by avoiding compatibility issues with newer setuptools versions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix a build issue by pinning the setuptools dependency to <=63. While this addresses the build problem, it introduces a critical conflict with requirements_dev.txt and requirements_tests.txt, which require setuptools>=65.5.1 to mitigate a security vulnerability. This conflict will break development and test environment setups. The proposed change pits a build fix against a security fix. The recommended course of action is to investigate why the build fails with newer setuptools versions and fix the underlying issue, which would be a more robust and secure solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GeoNode 4.4.x does not build due to dependecy issue

2 participants