Skip to content

add support for prefix invalidation#600

Closed
deniak wants to merge 10 commits intoFriendsOfSymfony:3.xfrom
deniak:3.x
Closed

add support for prefix invalidation#600
deniak wants to merge 10 commits intoFriendsOfSymfony:3.xfrom
deniak:3.x

Conversation

@deniak
Copy link
Contributor

@deniak deniak commented Mar 4, 2026

Cloudflare supports the invalidation by prefix.
That PR adds support for that method.

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this pull request. prefix is basicaly a special case of ban that does not allow wildcards anywhere else than at the end, right?

Multiplexer should multiplex prefix and noop implement prefix without doing anything.
we could make all clients that support ban support prefix, by converting the prefix into a banPath statement. do you think you can add that to the varnish client?

@dbu
Copy link
Contributor

dbu commented Mar 4, 2026

please rebase on the 3.x branch to get the cleanup of phpstan that i did. after that, if phpstan is not green it would be because of changes in this branch.

@deniak
Copy link
Contributor Author

deniak commented Mar 4, 2026

thanks for this pull request. prefix is basicaly a special case of ban that does not allow wildcards anywhere else than at the end, right?

Correct!

Multiplexer should multiplex prefix and noop implement prefix without doing anything. we could make all clients that support ban support prefix, by converting the prefix into a banPath statement. do you think you can add that to the varnish client?

I believe my last commits should address your suggestions. Thanks for the review.

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot! one last thing: can you please add tests for the invalidatePrefix that you added to more places, to keep the test coverage high?

@deniak deniak changed the title add suport for prefix invalidation add support for prefix invalidation Mar 4, 2026
@deniak
Copy link
Contributor Author

deniak commented Mar 4, 2026

thanks a lot! one last thing: can you please add tests for the invalidatePrefix that you added to more places, to keep the test coverage high?

Sorry I missed that. I added a few more tests.

@dbu
Copy link
Contributor

dbu commented Mar 4, 2026

thanks a lot! i added a changelog entry and merged on the cli.

i released this as 3.2.0 now.

@dbu dbu closed this Mar 4, 2026
@deniak
Copy link
Contributor Author

deniak commented Mar 4, 2026

Thanks @dbu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants