Skip to content

Fix confusion of buffer allocation model in comment#1334

Merged
AniruddhaKanhere merged 2 commits into
FreeRTOS:mainfrom
fxrb:fix-bufferallocation-confusion
May 11, 2026
Merged

Fix confusion of buffer allocation model in comment#1334
AniruddhaKanhere merged 2 commits into
FreeRTOS:mainfrom
fxrb:fix-bufferallocation-confusion

Conversation

@fxrb
Copy link
Copy Markdown
Contributor

@fxrb fxrb commented Apr 26, 2026

Special FromISR versions of these functions are available in BufferAllocation_1.c, not BufferAllocation_2.c.

Description

Test Steps

Checklist:

  • I have tested my changes. No regression in existing tests.

Related Issue

#1327 (comment)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Special FromISR versions of these functions are available in
BufferAllocation_1.c, not BufferAllocation_2.c.
@htibosch
Copy link
Copy Markdown
Contributor

htibosch commented May 7, 2026

Yes confusing when the C-comments are not correct.
BufferAllocation_2 uses the heap, which may not be allocated or freed during an ISR.
Both @cookpate and @aggarg approved it, and so do I. Shall we merge it?

@AniruddhaKanhere AniruddhaKanhere enabled auto-merge (rebase) May 11, 2026 19:52
@AniruddhaKanhere AniruddhaKanhere disabled auto-merge May 11, 2026 20:12
@AniruddhaKanhere AniruddhaKanhere merged commit ea087a3 into FreeRTOS:main May 11, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants