Skip to content

fix: update CSS selector for hiding fake footer row in Vaadin 25#174

Merged
paodb merged 1 commit intomasterfrom
fix-172
Mar 26, 2026
Merged

fix: update CSS selector for hiding fake footer row in Vaadin 25#174
paodb merged 1 commit intomasterfrom
fix-172

Conversation

@javier-godoy
Copy link
Copy Markdown
Member

@javier-godoy javier-godoy commented Mar 26, 2026

Close #172

Summary by CodeRabbit

  • Bug Fixes
    • Fixed the first footer row visibility behavior in Grid component when applying the hide-first-footer theme variant.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 11975da2-48da-434d-b87d-bfa4e31eb194

📥 Commits

Reviewing files that changed from the base of the PR and between 0e7219c and b55911b.

📒 Files selected for processing (1)
  • src/main/resources/META-INF/frontend/fcGridHelper/vaadin-grid.css

Walkthrough

This change updates a CSS selector in the Vaadin grid stylesheet to properly target footer rows using attribute substring matching instead of exact attribute matching. The copyright year was also updated to 2026.

Changes

Cohort / File(s) Summary
CSS Selector Fix
src/main/resources/META-INF/frontend/fcGridHelper/vaadin-grid.css
Modified CSS selector from [part="row"]:first-child to [part~="row"]:first-child for the hide-first-footer theme to correctly hide the first footer row. Updated copyright year to 2026.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • mlopezFC
  • paodb
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating a CSS selector to fix the fake footer row issue in Vaadin 25 grids.
Linked Issues check ✅ Passed The code change directly addresses issue #172 by modifying the CSS selector to properly hide the fake footer row that appears above the FooterToolbar in Vaadin 25.
Out of Scope Changes check ✅ Passed The changes are focused solely on fixing the reported issue: updating the CSS selector and copyright year, with no unrelated modifications present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-172

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@javier-godoy javier-godoy requested review from mlopezFC and paodb March 26, 2026 17:48
@javier-godoy javier-godoy marked this pull request as ready for review March 26, 2026 17:48
@paodb paodb merged commit 8ae8fea into master Mar 26, 2026
5 checks passed
@paodb paodb deleted the fix-172 branch March 26, 2026 17:54
@github-project-automation github-project-automation bot moved this from To Do to Pending release in Flowing Code Addons Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending release

Development

Successfully merging this pull request may close these issues.

Vaadin 25: FooterToolbar displays empty row above the actual Toolbar

2 participants