Skip to content

ci: configure vaadin-dev as optional dependency#170

Merged
paodb merged 1 commit intomasterfrom
javier-godoy-patch-1
Jan 28, 2026
Merged

ci: configure vaadin-dev as optional dependency#170
paodb merged 1 commit intomasterfrom
javier-godoy-patch-1

Conversation

@javier-godoy
Copy link
Copy Markdown
Member

@javier-godoy javier-godoy commented Jan 21, 2026

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated build configuration to mark a development dependency as optional.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 21, 2026

Walkthrough

Marks the vaadin-dev dependency as optional within the Maven v25 profile by adding an <optional>true</optional> element to its declaration in pom.xml. No logic or control flow changes.

Changes

Cohort / File(s) Summary
Maven Configuration
pom.xml
Modified vaadin-dev dependency in v25 profile to mark as optional by adding <optional>true</optional> element

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • mlopezFC
  • paodb
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: configuring vaadin-dev as an optional dependency in pom.xml, which matches the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@javier-godoy javier-godoy requested a review from paodb January 21, 2026 18:17
@javier-godoy javier-godoy marked this pull request as ready for review January 21, 2026 18:17
@javier-godoy javier-godoy requested a review from mlopezFC January 28, 2026 13:42
@paodb paodb merged commit 0e7219c into master Jan 28, 2026
5 checks passed
@github-project-automation github-project-automation bot moved this from To Do to Pending release in Flowing Code Addons Jan 28, 2026
@paodb paodb deleted the javier-godoy-patch-1 branch January 28, 2026 18:26
@javier-godoy javier-godoy moved this from Pending release to Done in Flowing Code Addons Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants