Skip to content

fix(pag): Incorrect calculation of last used page #8772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dyemanov merged 3 commits into from
Mar 21, 2026
+16 −13
Merged

fix(pag): Incorrect calculation of last used page #8772

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91a29a8
fix(pag): Incorrect calculation of last used page
Oct 13, 2025
226ace2
Revert "fix(pag): Incorrect calculation of last used page"
Mar 20, 2026
0f2e2ba
fix(pag): Incorrect calculation of last used page
Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions src/jrd/pag.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1824,27 +1824,30 @@ ULONG PageSpace::lastUsedPage()

const page_inv_page* pip = (page_inv_page*) window.win_buffer;

int last_bit = pip->pip_used;
int byte_num = last_bit / 8;
UCHAR mask = 1 << (last_bit % 8);
while (last_bit >= 0 && (pip->pip_bits[byte_num] & mask))
int last_bit = pip->pip_used - 1;
if (pip->pip_used > 0)
{
if (mask == 1)
int byte_num = last_bit / 8;
UCHAR mask = 1 << (last_bit % 8);
while (last_bit >= 0 && (pip->pip_bits[byte_num] & mask))
{
mask = 0x80;
byte_num--;
//fb_assert(byte_num > -1); ???
}
else
mask >>= 1;
if (mask == 1)
{
mask = 0x80;
byte_num--;
//fb_assert(byte_num > -1); ???
}
else
mask >>= 1;

last_bit--;
last_bit--;
}
}

CCH_RELEASE(tdbb, &window);
pipMaxKnown = pipLast;

return last_bit + (pipLast == pipFirst ? 0 : pipLast);
return last_bit + 1 + (pipLast == pipFirst ? 0 : pipLast);
}

ULONG PageSpace::lastUsedPage(const Database* dbb)
Expand Down
Loading