docs: document v2 components by droguljic · Pull Request #212 · ExtensionEngine/infra-code-blocks

droguljic · 2026-05-05T15:46:45Z

Documentation for v2, generated with the help of AI. Component specific documentation is moved into their respective folders, main README.md only references it.
The examples folder is for now removed and replaced partially by the in documentation examples.

Documentation for v2, generated with the help of AI. Component specific documentation is moved into their respective folders, main `README.md` only references it. The `examples` folder is for now removed and replaced partially by the in documentation examples.

MiroDojkic · 2026-05-06T12:58:24Z

I think the best test for the docs would be to have someone who hasn't worked much with icb, to try and deploy some of the components just using the docs.
Saying this cause I remember when I had to use it heavily, I quickly reached for the code examples due to documentation not really helping me in an effective way.

mandryllo · 2026-05-11T08:45:28Z

+- The primary subnet group always uses `vpc.isolatedSubnetIds`, and the database is always created with `publiclyAccessible: false`.
+- The database security group allows TCP/5432 from the VPC CIDR block.
+- The primary password is always managed through a nested `Password` component. If you omit `password`, that nested component generates a random password and stores it in Secrets Manager.
+- `Database` creates replicas sequentially. Each replica depends on the previous primary/replica instance rather than creating all replicas in parallel.


Maybe add explanation why it need to create them sequentially?

mandryllo · 2026-05-11T08:46:41Z

+| `password`                 | `pulumi.Input<string>`                               | No       | generated by `Password` | If omitted, a nested `Password` component generates and stores the secret.                                              |
+| `engineVersion`            | `pulumi.Input<string>`                               | No       | `'17.2'`                | PostgreSQL engine version.                                                                                              |
+| `multiAz`                  | `pulumi.Input<boolean>`                              | No       | `false`                 | Multi-AZ toggle for the primary instance.                                                                               |
+| `instanceClass`            | `pulumi.Input<string>`                               | No       | `'db.t4g.micro'`        | Primary instance class.                                                                                                 |


Instance type of the RDS instance?

mandryllo · 2026-05-11T08:47:16Z

+| `allowMajorVersionUpgrade` | `pulumi.Input<boolean>`                              | No       | `false`                 | Passed through to the primary instance.                                                                                 |
+| `autoMinorVersionUpgrade`  | `pulumi.Input<boolean>`                              | No       | `true`                  | Passed through to the primary instance.                                                                                 |
+| `applyImmediately`         | `pulumi.Input<boolean>`                              | No       | `false`                 | Passed through to the primary instance.                                                                                 |
+| `skipFinalSnapshot`        | `pulumi.Input<boolean>`                              | No       | `false`                 | Passed through to the primary instance.                                                                                 |


Add more specific description

mandryllo · 2026-05-11T08:48:23Z

+| `applyImmediately`         | `pulumi.Input<boolean>`                              | No       | `false`          | Passed through to the replica instance.                             |
+| `allowMajorVersionUpgrade` | `pulumi.Input<boolean>`                              | No       | `false`          | Passed through to the replica instance.                             |
+| `autoMinorVersionUpgrade`  | `pulumi.Input<boolean>`                              | No       | `true`           | Passed through to the replica instance.                             |


Add more specific description

mandryllo · 2026-05-11T08:49:56Z

+| `parameterGroupName`       | `pulumi.Input<string>`                               | No       | none                    | Optional DB parameter group name for the primary instance.                                                              |
+| `kmsKeyId`                 | `pulumi.Input<string>`                               | No       | generated KMS key ARN   | Override for storage encryption and encrypted snapshot copies.                                                          |
+| `replicaConfigs`           | `Map<string, Database.ReplicaConfig>`                | No       | none                    | Ordered map of replica names to configs. Replicas are created sequentially in insertion order.                          |
+| `enableSSMConnect`         | `pulumi.Input<boolean>`                              | No       | `false`                 | Creates the nested `Ec2SSMConnect` helper when truthy.                                                                  |


Maybe change the wording from helper to something else? It's used on multiple places in the file for Ec2SSMConnect

bornast · 2026-05-13T12:55:23Z

+**Outputs**
+
+| Output           | Type                          | Description                                                                 |
+| ---------------- | ----------------------------- | --------------------------------------------------------------------------- | ----------------------------------------------------------------------------- |
+| `name`           | `string`                      | Component name passed to the constructor.                                   |
+| `distribution`   | `aws.cloudfront.Distribution` | Primary CloudFront distribution resource configured from the behavior list. |
+| `acmCertificate` | `AcmCertificate               | undefined`                                                                  | Auto-created ACM certificate when `domain` is provided without `certificate`. |


This table is not being displayed properly

bornast · 2026-05-13T13:12:01Z

+  )
+  .build();
+
+export const dashboards = [logsAndTracesDashboard, customDashboard];


this is a bit misleading as someone would think that these are the actual resources while they are actually functions.

bornast · 2026-05-13T13:22:34Z

+### Happy path
+


The happy path shows a builder with .addAmp() but the focus of this README is the connection classes. The example is essentially the same pattern you'd see in the main Grafana README. A better happy path for this file would show constructing an AMPConnection directly, or highlight that addAmp() is the shorthand for creating an AMPConnection under the hood.

bornast · 2026-05-13T13:30:31Z

+  )
+  .build();
+
+export const panelFactory = sloSummaryDashboard;


this is not a panel factory

bornast · 2026-05-13T13:32:59Z

+- `createBurnRatePanel()` ignores `metric.thresholds` and always returns a `stat` panel with `unit: 'none'`, `reduceOptions.calcs = ['last']`, `colorMode: 'value'`, `graphMode: 'none'`, `textMode: 'value'`, and fixed green/orange/red thresholds at `null`, `1`, and `2`.
+- The availability, success-rate, and latency helpers each return fixed titles and fixed grid positions so they compose into the package's standard SLO dashboard layout.
+- `createAvailabilityPanel()` accepts `target` for config-shape consistency, but the generated availability query itself does not use it.
+- Some SLO panel titles are hard-coded with `250ms`; changing `targetLatency` changes the generated PromQL threshold but does not change those panel titles.


this sounds like a bug 😂
Some SLO panel titles are hard-coded with 250ms; changing targetLatency changes the generated PromQL threshold but does not change those panel titles.

bornast · 2026-05-13T13:34:10Z

@@ -0,0 +1,326 @@
+# `src/components/grafana/connections`


Maybe we should add an example of how to create a custom connection class?

droguljic added this to the v2 milestone May 5, 2026

droguljic requested review from MiroDojkic, bornast and mandryllo May 5, 2026 15:46

This was referenced May 6, 2026

refactor: remove unused UpstashRedis default dbName #213

Open

fix: sort out Vpc public API #214

Open

feat: bump default Database engine version to Postgres 18 #215

Open

feat: support full load balancer health check configuration #218

Open

mandryllo reviewed May 12, 2026

View reviewed changes

bornast requested changes May 13, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: document v2 components#212

docs: document v2 components#212
droguljic wants to merge 1 commit into
masterfrom
docs/v2-update

droguljic commented May 5, 2026

Uh oh!

MiroDojkic commented May 6, 2026

Uh oh!

mandryllo May 11, 2026

Uh oh!

mandryllo May 11, 2026

Uh oh!

mandryllo May 11, 2026

Uh oh!

mandryllo May 11, 2026

Uh oh!

mandryllo May 11, 2026

Uh oh!

bornast May 13, 2026

Uh oh!

bornast May 13, 2026

Uh oh!

bornast May 13, 2026

Uh oh!

bornast May 13, 2026

Uh oh!

bornast May 13, 2026 •

edited

Loading

Uh oh!

bornast May 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

droguljic commented May 5, 2026

Uh oh!

MiroDojkic commented May 6, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bornast May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bornast May 13, 2026 •

edited

Loading