feat: implement native bundle hash verification on iOS and Android#1
Merged
Merged
Conversation
JS-side response.arrayBuffer() on ~70 MB bundles triggers an engine-level abort in Hermes that bypasses the promise chain entirely. Move the download, SHA-256 hashing, and constant-time comparison into native code on both platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
loadVerified was implemented in JS: fetch the bundle, call response.arrayBuffer(), hash in TypeScript. On large bundles, Hermes throws a RangeError at the engine level
(uncatchable).
Changes:
Verified: tested end-to-end on iOS and Android by scanning a QR code pointing to a real S3 bundle with a correct SHA-256. Bridge reloaded from the verified file on both
platforms. On Android, confirmed one-shot behaviour: remote bundle active for one session, cold restart returns to Metro.