make animationSpeed decalregistry handler accept floats#1097
Merged
microlith57 merged 1 commit intoEverestAPI:devfrom Mar 30, 2026
Merged
make animationSpeed decalregistry handler accept floats#1097microlith57 merged 1 commit intoEverestAPI:devfrom
microlith57 merged 1 commit intoEverestAPI:devfrom
Conversation
maddie480-bot
added
the
1: review needed
JaThePlayer
approved these changes
Mar 25, 2026
microlith57
added
the
2: testing needed
SnipUndercover
approved these changes
Mar 30, 2026
Member
SnipUndercover
left a comment
SnipUndercover
left a comment
There was a problem hiding this comment.
Considering it compiles I don't think testing before dev is necessary. It's just a type change that we can easily roll back if for whatever reason it combusts.
microlith57
removed
the
2: testing needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the underlying field is a
float, so the handler should also accept floatsalso fixed some whitespace