Fix heap use-after-free in shared object loading#835
Open
barnabasdomozi wants to merge 1 commit intoEricsson:masterfrom
Open
Fix heap use-after-free in shared object loading#835barnabasdomozi wants to merge 1 commit intoEricsson:masterfrom
barnabasdomozi wants to merge 1 commit intoEricsson:masterfrom
Conversation
The bug was first observed in the CI pipeline, which occasionally failed with a free(): invalid pointer error. Building the project with AddressSanitizer enabled revealed a heap use-after-free issue. It was introduced by Python plugin PR (commit f69d6db), which modified how plugin shared objects are loaded. If both cppparser and cxxmetricsparser plugins are loaded with dlopen using the RTLD_GLOBAL flag, the global objects in these shared libraries conflict on unload, causing a use-after-free error. As a solution, we reverted to the previous behavior: all shared objects are loaded with RTLD_NOW by default, and only the pythonparser shared object is loaded with RTLD_GLOBAL.
barnabasdomozi
added
Plugin: C++
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug was first observed in the CI pipeline, which occasionally failed with a free(): invalid pointer error. Building the project with AddressSanitizer enabled revealed a heap use-after-free issue.
It was introduced by Python plugin PR
(commit f69d6db), which modified how plugin shared objects are loaded. If both cppparser and cxxmetricsparser plugins are loaded with dlopen using the RTLD_GLOBAL flag, the global objects in these shared libraries conflict on unload, causing a use-after-free error.
As a solution, we reverted to the previous behavior: all shared objects are loaded with RTLD_NOW by default, and only the pythonparser shared object is loaded with RTLD_GLOBAL.