Conversation
me4502
left a comment
me4502
left a comment
There was a problem hiding this comment.
Thanks for this. It appears to mostly follow along with the same goals from the WorldEdit Folia support.
I've left a few comments on some parts that I feel would be worth cleaning up
|
That should be good, I also took the liberty of removing duplicates for |
| vehicle.teleport(override.clone()); | ||
| Location vehicleTeleportLocation = override.clone(); | ||
| if (getPlugin().isFolia()) { | ||
| PaperLib.teleportAsync(vehicle, vehicleTeleportLocation); |
There was a problem hiding this comment.
I don't think there is a reason to use PaperLib only for folia. Imo we could always use PaperLib which provides fallback stuff for spigot.
There was a problem hiding this comment.
The potential problem would be that there could be a desynchronization between several teleportations on the Paper or Bukkit servers, which are currently a synchronous call
An issue has been created for WorldEdit regarding an API; if we know it won't cause any problems, I can merge using PaperLib for Bukkit like Folia.
There was a problem hiding this comment.
I feel for now, it's better to just do minimal changes for Folia support. We can do better testing as to whatever async teleports work well on Paper later, but I feel that part is out of scope for this PR
me4502
left a comment
me4502
left a comment
There was a problem hiding this comment.
Thanks for this, overall IMO these changes are a good basis for Folia support in WorldGuard.
| @@ -1,5 +1,5 @@ | |||
| [versions] | |||
| worldedit = "7.3.18" | |||
| worldedit = "7.4.1-SNAPSHOT" | |||
There was a problem hiding this comment.
Is this actually using anything from the new WorldEdit release? Generally we try to not target snapshots (if it's using something from 7.4, building against 7.4.0 would be preferred)
There was a problem hiding this comment.
I simply forgot to change it back to how it was before, because I originally wanted to use WorldEditPlugin#isFolia but it's protected.
There was a problem hiding this comment.
Would you be able to please revert that change then? Also possibly the bstats one below, unless that version bump is related to Folia support in some way
There was a problem hiding this comment.
It's been reverted to the previous state.
And for Bstats, the version upgrade includes Folia support.
3 participants
Following the basic Folia support for WorldEdit, this PR adds basic Folia support.
Some testing still needs to be done.