Skip to content

improve customer list device display ui#1432

Merged
beesaferoot merged 5 commits intomainfrom
improve-customer-devices-ui
Apr 14, 2026
Merged

improve customer list device display ui#1432
beesaferoot merged 5 commits intomainfrom
improve-customer-devices-ui

Conversation

@beesaferoot
Copy link
Copy Markdown
Contributor

@beesaferoot beesaferoot commented Apr 9, 2026

Closes #1431

Brief summary of the change made

Are there any other side effects of this change that we should be aware of?

Describe how you tested your changes?

Screenshot 2026-04-09 at 1 54 46 PM

Pull Request checklist

Please confirm you have completed any of the necessary steps below.

  • Meaningful Pull Request title and description
  • Changes tested as described above
  • Added appropriate documentation for the change.
  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@beesaferoot beesaferoot requested a review from dmohns April 9, 2026 12:38
@dmohns
Copy link
Copy Markdown
Member

dmohns commented Apr 14, 2026

I like it 🤩

One comment, other than that LGTM

  • The serial numbers currently get truncated from the right. However, device might have serial numbers that only differ in the last few digits. In the current UI it's hard to distinguish:
    image

    Could we truncate the middle instead? Similar to what ellipsizeMode="middle" does in React?

@beesaferoot
Copy link
Copy Markdown
Contributor Author

@dmohns I've addressed your comment, can you check again?

Copy link
Copy Markdown
Member

@dmohns dmohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@beesaferoot beesaferoot merged commit ba35c55 into main Apr 14, 2026
17 checks passed
@beesaferoot beesaferoot deleted the improve-customer-devices-ui branch April 14, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Improve Assigned Devices list display view on Customer list Page

2 participants