Wallet: don't create transaction chains that will be rejected by mempool by default#1535
Open
tomt1664 wants to merge 2 commits intoElementsProject:elements-23.xfrom
Open
Wallet: don't create transaction chains that will be rejected by mempool by default#1535tomt1664 wants to merge 2 commits intoElementsProject:elements-23.xfrom
tomt1664 wants to merge 2 commits intoElementsProject:elements-23.xfrom
Conversation
da2bc86 [wallet] don't create long chains by default (glozow) Additional functional test for too-long-chains rejected. Pull request description: Default mempool policy doesn't let you have chains longer than 25 transactions. This is locally configurable of course, but it's not really safe to assume that a chain longer than 25 transactions will propagate. Thus, the wallet should probably avoid creating such transactions by default; set `DEFAULT_WALLET_REJECT_LONG_CHAINS` to true. Closes #9752 Closes #10004 ACKs for top commit: MarcoFalke: re-ACK da2bc86 only change is fixing typos in tests 🎏 Tree-SHA512: 65d8e4ec437fe928adf554aa7e819a52e0599b403d5310895f4e371e99bbc838219b3097c4d2f775bc870ac617ef6b4227b94291f2b376f824f14e8f2b152f31
delta1
approved these changes
Mar 2, 2026
| options = {"include_unsafe": True, 'add_inputs': True} | ||
| # Sending one more chained transaction will fail | ||
| options = {"include_unsafe": True, 'add_inputs': True} | ||
| assert_raises_rpc_error(-4, "Insufficient funds", |
Member
There was a problem hiding this comment.
It would be nice to have a better error message here but I see that's quite an invasive change
Member
Author
There was a problem hiding this comment.
It is possible to apply a modified version of bitcoin/bitcoin#24845 - but it changes spend.cpp substantially, and will most likely cause issues for any future merges.
Member
There was a problem hiding this comment.
True but this PR is for elements-23.x branch?
Member
Author
There was a problem hiding this comment.
Yes - it is unlikely (but possible) there will be future bug fixes that will need to go in here before support is discontinued.
Co-authored-by: Byron Hambly <byron@hambly.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick of bitcoin/bitcoin#24502 with additional functional test to check rejection.