Fixing two issues with the pretty printing of operators that are not applied to arguments#929
Open
alleystoughton wants to merge 1 commit intomainfrom
Open
Fixing two issues with the pretty printing of operators that are not applied to arguments#929alleystoughton wants to merge 1 commit intomainfrom
alleystoughton wants to merge 1 commit intomainfrom
Conversation
applied to arguments. The first is unnecessary qualification, in some cases. The second is pretty printing qualified unary operators in a way that fails to parse. #close #854
Member
Author
|
Issue #928 is orthogonal to this fix. |
strub
requested changes
Mar 10, 2026
| -> | ||
| let negop = EcPath.pqoname (EcPath.prefix op') "<>" in | ||
| pp_opapp ppe outer fmt (negop, tys, [f1; f2]) | ||
| pp_opapp ppe outer fmt (negop, tys, [f1; f2], None) |
|
|
||
| | Fapp ({f_node = Fop (p, tys)}, args) -> | ||
| pp_opapp ppe outer fmt (p, tys, args) | ||
| pp_opapp ppe outer fmt (p, tys, args, None) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing two issues with the pretty printing of operators that are not applied to arguments. The first is unnecessary qualification, in some cases. The second is pretty printing qualified unary operators in a way that fails to parse.
close #854