Add condition and test for explicit set of no PS1 by adammccartney · Pull Request #192 · EESSI/software-layer-scripts

adammccartney · 2026-03-25T13:01:18Z

This implements the behavior described in #187 , make it possible for the user to explicitly unset the EESSI PS1.
This PR replaces #188.

adammccartney · 2026-03-25T13:03:26Z

@ocaisa can you run the test for this please, I could only test manually on our system.

ocaisa

Can you also update the comment line 28 to explain what happens by default, and how to explicitly disable it.

.github/workflows/scripts/test_init_scripts.sh

init/lmod/sh

Co-authored-by: ocaisa <alan.ocais@cecam.org>

init/lmod/sh

ocaisa

Can you just add some clarification to the comment at line 28 to explain the default and how to explicitly disable it. The complication is that

init/lmod/sh

ocaisa

LGTM

ocaisa · 2026-03-25T14:40:01Z

bot: build repo:eessi.io-2023.06-software instance:eessi-bot-deucalion for:arch=aarch64/a64fx
bot: build repo:eessi.io-2025.06-software instance:eessi-bot-deucalion for:arch=aarch64/a64fx

eessi-bot-deucalion · 2026-03-25T14:40:10Z

New job on instance eessi-bot-deucalion for repository eessi.io-2023.06-software
Building on: a64fx
Building for: aarch64/a64fx
Job dir: /home/eessibot/new-bot/jobs/2026.03/pr_192/1074488

date	job status	comment
Mar 25 14:40:09 UTC 2026	submitted	job id `1074488` awaits release by job manager
Mar 25 14:40:29 UTC 2026	released	job awaits launch by Slurm scheduler
Mar 25 14:41:34 UTC 2026	running	job `1074488` is running
Mar 25 14:51:21 UTC 2026	finished	😁 SUCCESS (click triangle for details) Details ✅ job output file `slurm-1074488.out` ✅ no message matching `FATAL:` ✅ no message matching `ERROR:` ✅ no message matching `FAILED:` ✅ no message matching `required modules missing:` ✅ found message(s) matching `No missing installations` ✅ found message matching `.tar.* created!` Artefacts `eessi-2023.06-software-linux-aarch64-a64fx-17744498300.tar.zst` size: 0 MiB (3165 bytes) entries: 4 modules under 2023.06/software/linux/aarch64/a64fx/modules/all no module files in tarball software under 2023.06/software/linux/aarch64/a64fx/software no software packages in tarball reprod directories under 2023.06/software/linux/aarch64/a64fx/reprod no reprod directories in tarball other under 2023.06/software/linux/aarch64/a64fx `2023.06/init/lmod/bash` `2023.06/init/lmod/ksh` `2023.06/init/lmod/sh` `2023.06/init/lmod/zsh`
Mar 25 14:51:21 UTC 2026	test result	😁 SUCCESS (click triangle for details) ReFrame Summary [ SKIP ] ( 1/10) Skipping test: nodes in this partition only have 30720 MiB memory available (per node) according to the current ReFrame configuration, but 49152 MiB is needed [ SKIP ] ( 2/10) Skipping test: nodes in this partition only have 30720 MiB memory available (per node) according to the current ReFrame configuration, but 49152 MiB is needed [ SKIP ] ( 3/10) Skipping test: nodes in this partition only have 30720 MiB memory available (per node) according to the current ReFrame configuration, but 49152 MiB is needed [ SKIP ] ( 4/10) Skipping test: nodes in this partition only have 30720 MiB memory available (per node) according to the current ReFrame configuration, but 49152 MiB is needed [ OK ] ( 5/10) EESSI_LAMMPS_lj %device_type=cpu %module_name=LAMMPS/29Aug2024-foss-2023b-kokkos %scale=1_node /aeb2d9df @BotBuildTests:a64fx+default P: perf: 580.647 timesteps/s (r:0, l:None, u:None) [ OK ] ( 6/10) EESSI_LAMMPS_lj %device_type=cpu %module_name=LAMMPS/2Aug2023_update2-foss-2023a-kokkos %scale=1_node /04ff9ece @BotBuildTests:a64fx+default P: perf: 583.465 timesteps/s (r:0, l:None, u:None) [ OK ] ( 7/10) EESSI_OSU_pt2pt_CPU %benchmark_info=mpi.pt2pt.osu_latency %module_name=OSU-Micro-Benchmarks/7.2-gompi-2023b %scale=1_node /15cad6c4 @BotBuildTests:a64fx+default P: latency: 1.67 us (r:0, l:None, u:None) [ OK ] ( 8/10) EESSI_OSU_pt2pt_CPU %benchmark_info=mpi.pt2pt.osu_latency %module_name=OSU-Micro-Benchmarks/7.1-1-gompi-2023a %scale=1_node /6672deda @BotBuildTests:a64fx+default P: latency: 1.72 us (r:0, l:None, u:None) [ OK ] ( 9/10) EESSI_OSU_pt2pt_CPU %benchmark_info=mpi.pt2pt.osu_bw %module_name=OSU-Micro-Benchmarks/7.2-gompi-2023b %scale=1_node /2a9a47b1 @BotBuildTests:a64fx+default P: bandwidth: 8171.48 MB/s (r:0, l:None, u:None) [ OK ] (10/10) EESSI_OSU_pt2pt_CPU %benchmark_info=mpi.pt2pt.osu_bw %module_name=OSU-Micro-Benchmarks/7.1-1-gompi-2023a %scale=1_node /1b24ab8e @BotBuildTests:a64fx+default P: bandwidth: 8596.91 MB/s (r:0, l:None, u:None) [ PASSED ] Ran 6/10 test case(s) from 10 check(s) (0 failure(s), 4 skipped, 0 aborted) Details ✅ job output file `slurm-1074488.out` ✅ no message matching `ERROR:` ✅ no message matching `[\sFAILED\s].Ran . test case`
Mar 25 15:06:27 UTC 2026	uploaded	transfer of `eessi-2023.06-software-linux-aarch64-a64fx-17744498300.tar.zst` to S3 bucket succeeded

eessi-bot-deucalion · 2026-03-25T14:40:18Z

New job on instance eessi-bot-deucalion for repository eessi.io-2025.06-software
Building on: a64fx
Building for: aarch64/a64fx
Job dir: /home/eessibot/new-bot/jobs/2026.03/pr_192/1074489

date	job status	comment
Mar 25 14:40:16 UTC 2026	submitted	job id `1074489` awaits release by job manager
Mar 25 14:40:26 UTC 2026	released	job awaits launch by Slurm scheduler
Mar 25 14:41:37 UTC 2026	running	job `1074489` is running
Mar 25 14:48:10 UTC 2026	finished	😁 SUCCESS (click triangle for details) Details ✅ job output file `slurm-1074489.out` ✅ no message matching `FATAL:` ✅ no message matching `ERROR:` ✅ no message matching `FAILED:` ✅ no message matching `required modules missing:` ✅ found message(s) matching `No missing installations` ✅ found message matching `.tar.* created!` Artefacts `eessi-2025.06-software-linux-aarch64-a64fx-17744497810.tar.zst` size: 0 MiB (3167 bytes) entries: 4 modules under 2025.06/software/linux/aarch64/a64fx/modules/all no module files in tarball software under 2025.06/software/linux/aarch64/a64fx/software no software packages in tarball reprod directories under 2025.06/software/linux/aarch64/a64fx/reprod no reprod directories in tarball other under 2025.06/software/linux/aarch64/a64fx `2025.06/init/lmod/bash` `2025.06/init/lmod/ksh` `2025.06/init/lmod/sh` `2025.06/init/lmod/zsh`
Mar 25 14:48:10 UTC 2026	test result	😁 SUCCESS (click triangle for details) ReFrame Summary [ SKIP ] (1/4) EESSI_OSU_coll %benchmark_info=mpi.collective.osu_allreduce %module_name=OSU-Micro-Benchmarks/7.5-gompi-2025a %scale=1_node %device_type=cpu /e4bf9965 @BotBuildTests:a64fx+default [Skipping test: nodes in this partition only have 30720 MiB memory available (per node) according to the current ReFrame configuration, but 49152 MiB is needed] [ SKIP ] (2/4) EESSI_OSU_coll %benchmark_info=mpi.collective.osu_alltoall %module_name=OSU-Micro-Benchmarks/7.5-gompi-2025a %scale=1_node %device_type=cpu /3da4890b @BotBuildTests:a64fx+default [Skipping test: nodes in this partition only have 30720 MiB memory available (per node) according to the current ReFrame configuration, but 49152 MiB is needed] [ OK ] (3/4) EESSI_OSU_pt2pt_CPU %benchmark_info=mpi.pt2pt.osu_latency %module_name=OSU-Micro-Benchmarks/7.5-gompi-2025a %scale=1_node /3255009a @BotBuildTests:a64fx+default P: latency: 0.87 us (r:0, l:None, u:None) [ OK ] (4/4) EESSI_OSU_pt2pt_CPU %benchmark_info=mpi.pt2pt.osu_bw %module_name=OSU-Micro-Benchmarks/7.5-gompi-2025a %scale=1_node /59f4b331 @BotBuildTests:a64fx+default P: bandwidth: 8016.42 MB/s (r:0, l:None, u:None) [ PASSED ] Ran 2/4 test case(s) from 4 check(s) (0 failure(s), 2 skipped, 0 aborted) Details ✅ job output file `slurm-1074489.out` ✅ no message matching `ERROR:` ✅ no message matching `[\sFAILED\s].Ran . test case`
Mar 25 15:06:36 UTC 2026	uploaded	transfer of `eessi-2025.06-software-linux-aarch64-a64fx-17744497810.tar.zst` to S3 bucket succeeded

ocaisa · 2026-03-25T15:25:33Z

Staging PR has beem merged, should appear on our servers within the hour

adammccartney · 2026-03-25T15:29:08Z

Wow, that's a pretty quick turnaround! Thanks a lot for the help.

Add condition and test for explicit set of no PS1

305b37d

adammccartney mentioned this pull request Mar 25, 2026

Make EESSI_MODULE_UPDATE_PS1 configurable #188

Closed

ocaisa requested changes Mar 25, 2026

View reviewed changes

.github/workflows/scripts/test_init_scripts.sh Show resolved Hide resolved

Merge branch 'main' into configure_eessi_module_update_ps1

591e966

ocaisa requested changes Mar 25, 2026

View reviewed changes

init/lmod/sh Outdated Show resolved Hide resolved

Tweak tests and remove unneeded code

329e317

Co-authored-by: ocaisa <alan.ocais@cecam.org>

adammccartney commented Mar 25, 2026

View reviewed changes

init/lmod/sh Show resolved Hide resolved

ocaisa reviewed Mar 25, 2026

View reviewed changes

init/lmod/sh Outdated Show resolved Hide resolved

ocaisa requested changes Mar 25, 2026

View reviewed changes

adammccartney commented Mar 25, 2026

View reviewed changes

init/lmod/sh Show resolved Hide resolved

adammccartney added 2 commits March 25, 2026 14:50

Move PS1 into block where EESSI_MODULE_UPDATE_PS1 is exported

0ea3ee9

Update comment

0432805

ocaisa reviewed Mar 25, 2026

View reviewed changes

init/lmod/sh Show resolved Hide resolved

Apply suggestion from @ocaisa

b6aa04e

ocaisa approved these changes Mar 25, 2026

View reviewed changes

ocaisa added the bot:deploy label Mar 25, 2026

ocaisa merged commit 655d651 into EESSI:main Mar 25, 2026
67 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add condition and test for explicit set of no PS1#192

Add condition and test for explicit set of no PS1#192
ocaisa merged 6 commits intoEESSI:mainfrom
adammccartney:configure_eessi_module_update_ps1

adammccartney commented Mar 25, 2026

Uh oh!

adammccartney commented Mar 25, 2026

Uh oh!

ocaisa left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ocaisa left a comment

Uh oh!

Uh oh!

Uh oh!

ocaisa left a comment

Uh oh!

ocaisa commented Mar 25, 2026

Uh oh!

eessi-bot-deucalion bot commented Mar 25, 2026 •

edited

Loading

Uh oh!

eessi-bot-deucalion bot commented Mar 25, 2026 •

edited

Loading

Uh oh!

ocaisa commented Mar 25, 2026

Uh oh!

Uh oh!

adammccartney commented Mar 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

adammccartney commented Mar 25, 2026

Uh oh!

adammccartney commented Mar 25, 2026

Uh oh!

ocaisa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ocaisa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ocaisa left a comment

Choose a reason for hiding this comment

Uh oh!

ocaisa commented Mar 25, 2026

Uh oh!

eessi-bot-deucalion bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eessi-bot-deucalion bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocaisa commented Mar 25, 2026

Uh oh!

Uh oh!

adammccartney commented Mar 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

eessi-bot-deucalion bot commented Mar 25, 2026 •

edited

Loading

eessi-bot-deucalion bot commented Mar 25, 2026 •

edited

Loading