Skip to content

Adds ability to read well positions#53

Open
Matt-Carre wants to merge 15 commits into
mainfrom
52_selection_grid
Open

Adds ability to read well positions#53
Matt-Carre wants to merge 15 commits into
mainfrom
52_selection_grid

Conversation

@Matt-Carre
Copy link
Copy Markdown
Collaborator

closes #52, allows for reading of coordinate system

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.58%. Comparing base (7f5c9ee) to head (8cfca21).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   96.55%   96.58%   +0.02%     
==========================================
  Files          20       20              
  Lines        1016     1024       +8     
==========================================
+ Hits          981      989       +8     
  Misses         35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@noemifrisina noemifrisina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's a start but it's actually missing half the request from the issue.

First thing is to get the run_positions for the specific run - this is done looking at the series_length which is the request of how many wells to collect in one detector arm. Once you have the list of wells per one arm you should get their coordinates.

To be fair, for initial testing it won't make that much of a difference as we're just going to be doing everything in one arm. This means it will end up being the same number dictionary you're getting here anyway, but it's good to set up the full functionality so we can see what changes will be needed in the plans/parameter model for bluesky

Comment thread tests/gui/test_eh2_ui.py Outdated
Comment thread src/i19serial_ui/coordinate_system/utils.py Outdated
Comment thread src/i19serial_ui/coordinate_system/utils.py Outdated
Comment thread src/i19serial_ui/gui/serial_gui_eh2.py
Copy link
Copy Markdown
Collaborator

@noemifrisina noemifrisina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, definitely looks simpler now, just a couple more things

Comment thread src/i19serial_ui/coordinate_system/utils.py Outdated
Comment thread src/i19serial_ui/coordinate_system/utils.py Outdated
Comment thread src/i19serial_ui/coordinate_system/utils.py Outdated
Comment thread tests/gui/test_eh2_ui.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set up a first version of run position selection

2 participants