Adds ability to read well positions#53
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
+ Coverage 96.55% 96.58% +0.02%
==========================================
Files 20 20
Lines 1016 1024 +8
==========================================
+ Hits 981 989 +8
Misses 35 35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
noemifrisina
left a comment
There was a problem hiding this comment.
Thanks, it's a start but it's actually missing half the request from the issue.
First thing is to get the run_positions for the specific run - this is done looking at the series_length which is the request of how many wells to collect in one detector arm. Once you have the list of wells per one arm you should get their coordinates.
To be fair, for initial testing it won't make that much of a difference as we're just going to be doing everything in one arm. This means it will end up being the same number dictionary you're getting here anyway, but it's good to set up the full functionality so we can see what changes will be needed in the plans/parameter model for bluesky
…_run_position_coordinates
noemifrisina
left a comment
There was a problem hiding this comment.
Thanks, definitely looks simpler now, just a couple more things
closes #52, allows for reading of coordinate system