feat: Add host CLI option as alternative to config#1395
feat: Add host CLI option as alternative to config#1395
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1395 +/- ##
==========================================
+ Coverage 95.16% 95.24% +0.08%
==========================================
Files 43 43
Lines 3080 3132 +52
==========================================
+ Hits 2931 2983 +52
Misses 149 149 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c3e9908 to
136df8d
Compare
3fde52e to
2d156a3
Compare
| $ref: '#/components/schemas/BasicAuthentication' | ||
| description: Auth information for communicating with STOMP broker, if required | ||
| title: Auth | ||
| enabled: |
There was a problem hiding this comment.
If we're freely giving the auth config away, is there much point having it?
There was a problem hiding this comment.
No, maybe we should discuss this now. The level of security going on at various points here is getting tenuous. Even if we decide not to do it in this PR (likely), we should have a plan on what we're going to do about it.
2cbe490 to
2533134
Compare
2533134 to
67ee7cb
Compare
67ee7cb to
3d17702
Compare
abbiemery
left a comment
There was a problem hiding this comment.
When trying to run scans against tiled 0.2.4 (current state of main) with this I am getting an error from the tiled writer:
TypeError: DataSource.__init__() got an unexpected keyword argument 'properties'
This may be just down to it needing rebasing but does raise the question of if we are clear somewhere about the versions of tiled we support.
Works against 0.2.3. Can login/out, get devices and run plans etc. Happy to approve pending a credential discussion.
| $ref: '#/components/schemas/BasicAuthentication' | ||
| description: Auth information for communicating with STOMP broker, if required | ||
| title: Auth | ||
| enabled: |
There was a problem hiding this comment.
No, maybe we should discuss this now. The level of security going on at various points here is getting tenuous. Even if we decide not to do it in this PR (likely), we should have a plan on what we're going to do about it.
| @@ -212,7 +208,7 @@ def __init__( | |||
| events: EventBusClient | None = None, | |||
| ): | |||
| self._rest = rest | |||
| self._events = events | |||
| self._event_bus_client = events | |||
There was a problem hiding this comment.
nit: consistency?
_rest_client: BlueapiRestClient
_event_bus_client: EventBusClient | None
_instrument_session: str | None = None
_callbacks: dict[int, OnAnyEvent]
_callback_id: itertools.count
def __init__(
self,
rest: BlueapiRestClient,
event_bus: EventBusClient | None = None,
):
self._rest_client = rest
self._event_bus_client = event_bus
No description provided.