Skip to content

feat: Add host CLI option as alternative to config#1395

Open
tpoliaw wants to merge 7 commits intomainfrom
client-host-option
Open

feat: Add host CLI option as alternative to config#1395
tpoliaw wants to merge 7 commits intomainfrom
client-host-option

Conversation

@tpoliaw
Copy link
Contributor

@tpoliaw tpoliaw commented Feb 16, 2026

No description provided.

@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.24%. Comparing base (be81937) to head (3d17702).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1395      +/-   ##
==========================================
+ Coverage   95.16%   95.24%   +0.08%     
==========================================
  Files          43       43              
  Lines        3080     3132      +52     
==========================================
+ Hits         2931     2983      +52     
  Misses        149      149              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tpoliaw tpoliaw force-pushed the config-parameters branch 2 times, most recently from c3e9908 to 136df8d Compare February 19, 2026 18:40
Base automatically changed from config-parameters to main February 19, 2026 18:45
$ref: '#/components/schemas/BasicAuthentication'
description: Auth information for communicating with STOMP broker, if required
title: Auth
enabled:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're freely giving the auth config away, is there much point having it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, maybe we should discuss this now. The level of security going on at various points here is getting tenuous. Even if we decide not to do it in this PR (likely), we should have a plan on what we're going to do about it.

@tpoliaw tpoliaw changed the title Add host option to remove need for client configuration feat: Add host CLI option as alternative to config Feb 23, 2026
@tpoliaw tpoliaw marked this pull request as ready for review February 23, 2026 17:47
@tpoliaw tpoliaw requested a review from a team as a code owner February 23, 2026 17:47
Copy link
Contributor

@abbiemery abbiemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When trying to run scans against tiled 0.2.4 (current state of main) with this I am getting an error from the tiled writer:

TypeError: DataSource.__init__() got an unexpected keyword argument 'properties'

This may be just down to it needing rebasing but does raise the question of if we are clear somewhere about the versions of tiled we support.

Works against 0.2.3. Can login/out, get devices and run plans etc. Happy to approve pending a credential discussion.

$ref: '#/components/schemas/BasicAuthentication'
description: Auth information for communicating with STOMP broker, if required
title: Auth
enabled:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, maybe we should discuss this now. The level of security going on at various points here is getting tenuous. Even if we decide not to do it in this PR (likely), we should have a plan on what we're going to do about it.

Comment on lines 199 to +211
@@ -212,7 +208,7 @@ def __init__(
events: EventBusClient | None = None,
):
self._rest = rest
self._events = events
self._event_bus_client = events
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: consistency?

    _rest_client: BlueapiRestClient
    _event_bus_client: EventBusClient | None
    _instrument_session: str | None = None
    _callbacks: dict[int, OnAnyEvent]
    _callback_id: itertools.count

    def __init__(
        self,
        rest: BlueapiRestClient,
        event_bus: EventBusClient | None = None,
    ):
        self._rest_client = rest
        self._event_bus_client = event_bus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants