Skip to content

Adds process tags to remote config payload#3658

Draft
dubloom wants to merge 3 commits intomasterfrom
dubloom/process-tags-rc
Draft

Adds process tags to remote config payload#3658
dubloom wants to merge 3 commits intomasterfrom
dubloom/process-tags-rc

Conversation

@dubloom
Copy link
Contributor

@dubloom dubloom commented Feb 17, 2026

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 17, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

❄️ 2 New flaky tests detected

tmp/build_extension/tests/ext/remote_config/process_tags.phpt (Test remote config request payload) from PHP.tmp.build_extension.tests.ext.remote_config (Datadog) (Fix with Cursor)
001+ ** ERROR: process timed out **
001- entrypoint.basedir:remote_config
002- entrypoint.name:process_tags
003- entrypoint.type:script
004- entrypoint.workdir:%s
005- runtime.sapi:cli
tmp/build_extension/tests/ext/remote_config/process_tags.phpt (Test remote config request payload) from php.tmp.build_extension.tests.ext.remote_config (Datadog) (Fix with Cursor)
001- entrypoint.basedir:remote_config
002- entrypoint.name:process_tags
003- entrypoint.type:script
004- entrypoint.workdir:%s
005- runtime.sapi:cli
001+ ERROR: No RC request found

🧪 1050 Tests failed

test anonymized auto user instrumentation() from com.datadog.appsec.php.integration.RemoteConfigTests (Datadog) (Fix with Cursor)
java.lang.AssertionError: No request with version 1772728387 gotten within 5000 ms for com.datadog.appsec.php.mock_agent.rem_cfg.Target(some-name, none, )

java.lang.AssertionError: No request with version 1772728387 gotten within 5000 ms for com.datadog.appsec.php.mock_agent.rem_cfg.Target(some-name, none, )
	at com.datadog.appsec.php.mock_agent.ConfigV07Handler.waitForVersion(ConfigV07Handler.groovy:72)
	at com.datadog.appsec.php.mock_agent.MockDatadogAgent.waitForRCVersion(MockDatadogAgent.groovy:80)
	at com.datadog.appsec.php.docker.AppSecContainer.waitForRCVersion(AppSecContainer.groovy:181)
	at com.datadog.appsec.php.docker.AppSecContainer$_applyRemoteConfig_closure6.doCall(AppSecContainer.groovy:233)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
...
test asm() from com.datadog.appsec.php.integration.RemoteConfigTests (Datadog) (Fix with Cursor)
java.lang.AssertionError: No request with version 1772728352 gotten within 5000 ms for com.datadog.appsec.php.mock_agent.rem_cfg.Target(some-name, none, )

java.lang.AssertionError: No request with version 1772728352 gotten within 5000 ms for com.datadog.appsec.php.mock_agent.rem_cfg.Target(some-name, none, )
	at com.datadog.appsec.php.mock_agent.ConfigV07Handler.waitForVersion(ConfigV07Handler.groovy:72)
	at com.datadog.appsec.php.mock_agent.MockDatadogAgent.waitForRCVersion(MockDatadogAgent.groovy:80)
	at com.datadog.appsec.php.docker.AppSecContainer.waitForRCVersion(AppSecContainer.groovy:181)
	at com.datadog.appsec.php.docker.AppSecContainer$_applyRemoteConfig_closure6.doCall(AppSecContainer.groovy:233)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
...
test asm_data() from com.datadog.appsec.php.integration.RemoteConfigTests (Datadog) (Fix with Cursor)
java.lang.AssertionError: No request with version 1772728372 gotten within 5000 ms for com.datadog.appsec.php.mock_agent.rem_cfg.Target(some-name, none, )

java.lang.AssertionError: No request with version 1772728372 gotten within 5000 ms for com.datadog.appsec.php.mock_agent.rem_cfg.Target(some-name, none, )
	at com.datadog.appsec.php.mock_agent.ConfigV07Handler.waitForVersion(ConfigV07Handler.groovy:72)
	at com.datadog.appsec.php.mock_agent.MockDatadogAgent.waitForRCVersion(MockDatadogAgent.groovy:80)
	at com.datadog.appsec.php.docker.AppSecContainer.waitForRCVersion(AppSecContainer.groovy:181)
	at com.datadog.appsec.php.docker.AppSecContainer$_applyRemoteConfig_closure6.doCall(AppSecContainer.groovy:233)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
...
View all
This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4aad6f6 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.08%. Comparing base (eebb4fe) to head (4aad6f6).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3658   +/-   ##
=======================================
  Coverage   62.08%   62.08%           
=======================================
  Files         141      141           
  Lines       13352    13352           
  Branches     1746     1746           
=======================================
  Hits         8290     8290           
  Misses       4269     4269           
  Partials      793      793           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eebb4fe...4aad6f6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Feb 17, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-03-05 17:39:55

Comparing candidate commit 4aad6f6 in PR branch dubloom/process-tags-rc with baseline commit eebb4fe in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 193 metrics, 0 unstable metrics.

scenario:PDOBench/benchPDOOverheadWithDBM

  • 🟥 execution_time [+5.546µs; +10.070µs] or [+2.526%; +4.587%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants