feat(rxjava3): add RxJava 3 context propagation instrumentation#11505
Draft
wconti27 wants to merge 8 commits into
Draft
feat(rxjava3): add RxJava 3 context propagation instrumentation#11505wconti27 wants to merge 8 commits into
wconti27 wants to merge 8 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
Remove toolkit-added skills (apm-integrations, datadog-semantics, observability-patterns) and restore .claude to match master branch. Remove the .claude/ .gitignore entry added by mistake.
97cd6bd to
a3779c2
Compare
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with APM Instrumentation Toolkit
What Does This Do
Adds instrumentation for RxJava 3 (
io.reactivex.rxjava3:rxjava) — context propagation across async reactive subscription boundaries for all 5 reactive types.Motivation
Customer request for RxJava 3 support. RxJava 2 instrumentation already exists; this extends coverage to the v3 API which uses a new package namespace (
io.reactivex.rxjava3.core).Additional Notes
Design: Context propagation only — no new spans created. Mirrors the existing
rxjava-2.0module exactly:subscribe()(wrap observer with tracing wrapper)Observable,Flowable,Single,Completable,Maybe— all 5 types instrumentedFlowablehandles twosubscribe()overloads:subscribe(Subscriber)andsubscribe(FlowableSubscriber)— the latter is new in RxJava 3 and shares a single Advice class viaDYNAMICtyping +TracingSubscriberimplementing both interfacesRxJava3AsyncResultExtension— equivalent ofRxJavaAsyncResultExtensionin rxjava-2.0, extends spans until reactive chains complete for@WithSpan-annotated methodsKnown limitation: Context propagation through
Maybe.delay()(computation scheduler) does not produce child spans in the current implementation — the delayed Flowable tests provide equivalent delay coverage. Tracked as a follow-up investigation.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsJira ticket: [PROJ-IDENT]
🤖 Generated with APM Instrumentation Toolkit