Piotr.wolski/capture kafka producer consumer configs#10697
Draft
piochelepiotr wants to merge 8 commits intomasterfrom
Draft
Piotr.wolski/capture kafka producer consumer configs#10697piochelepiotr wants to merge 8 commits intomasterfrom
piochelepiotr wants to merge 8 commits intomasterfrom
Conversation
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~fdf878839c, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1060086
Total [baseline] (11.101 s) : 0, 11100663
Agent [candidate] (1.075 s) : 0, 1074782
Total [candidate] (11.15 s) : 0, 11149888
section appsec
Agent [baseline] (1.248 s) : 0, 1247843
Total [baseline] (11.143 s) : 0, 11142585
Agent [candidate] (1.245 s) : 0, 1244781
Total [candidate] (11.101 s) : 0, 11101270
section iast
Agent [baseline] (1.227 s) : 0, 1227207
Total [baseline] (11.313 s) : 0, 11313400
Agent [candidate] (1.235 s) : 0, 1235072
Total [candidate] (11.321 s) : 0, 11321260
section profiling
Agent [baseline] (1.189 s) : 0, 1188656
Total [baseline] (11.032 s) : 0, 11031853
Agent [candidate] (1.18 s) : 0, 1179786
Total [candidate] (10.922 s) : 0, 10921923
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~fdf878839c, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.223 ms) : 0, 1223
BytebuddyAgent [baseline] (628.428 ms) : 0, 628428
BytebuddyAgent [candidate] (637.639 ms) : 0, 637639
AgentMeter [baseline] (29.184 ms) : 0, 29184
AgentMeter [candidate] (29.738 ms) : 0, 29738
GlobalTracer [baseline] (257.055 ms) : 0, 257055
GlobalTracer [candidate] (261.197 ms) : 0, 261197
AppSec [baseline] (31.449 ms) : 0, 31449
AppSec [candidate] (32.298 ms) : 0, 32298
Debugger [baseline] (59.504 ms) : 0, 59504
Debugger [candidate] (60.344 ms) : 0, 60344
Remote Config [baseline] (614.305 µs) : 0, 614
Remote Config [candidate] (603.242 µs) : 0, 603
Telemetry [baseline] (8.622 ms) : 0, 8622
Telemetry [candidate] (8.809 ms) : 0, 8809
Flare Poller [baseline] (7.954 ms) : 0, 7954
Flare Poller [candidate] (6.567 ms) : 0, 6567
section appsec
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.203 ms) : 0, 1203
BytebuddyAgent [baseline] (658.08 ms) : 0, 658080
BytebuddyAgent [candidate] (657.429 ms) : 0, 657429
AgentMeter [baseline] (12.105 ms) : 0, 12105
AgentMeter [candidate] (12.014 ms) : 0, 12014
GlobalTracer [baseline] (258.655 ms) : 0, 258655
GlobalTracer [candidate] (258.013 ms) : 0, 258013
AppSec [baseline] (178.308 ms) : 0, 178308
AppSec [candidate] (177.126 ms) : 0, 177126
Debugger [baseline] (65.974 ms) : 0, 65974
Debugger [candidate] (65.643 ms) : 0, 65643
Remote Config [baseline] (591.566 µs) : 0, 592
Remote Config [candidate] (570.668 µs) : 0, 571
Telemetry [baseline] (8.972 ms) : 0, 8972
Telemetry [candidate] (8.925 ms) : 0, 8925
Flare Poller [baseline] (3.663 ms) : 0, 3663
Flare Poller [candidate] (3.616 ms) : 0, 3616
IAST [baseline] (24.028 ms) : 0, 24028
IAST [candidate] (23.914 ms) : 0, 23914
section iast
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.219 ms) : 0, 1219
BytebuddyAgent [baseline] (795.674 ms) : 0, 795674
BytebuddyAgent [candidate] (801.656 ms) : 0, 801656
AgentMeter [baseline] (11.337 ms) : 0, 11337
AgentMeter [candidate] (11.568 ms) : 0, 11568
GlobalTracer [baseline] (247.49 ms) : 0, 247490
GlobalTracer [candidate] (248.658 ms) : 0, 248658
AppSec [baseline] (26.425 ms) : 0, 26425
AppSec [candidate] (26.564 ms) : 0, 26564
Debugger [baseline] (64.473 ms) : 0, 64473
Debugger [candidate] (64.257 ms) : 0, 64257
Remote Config [baseline] (525.692 µs) : 0, 526
Remote Config [candidate] (516.586 µs) : 0, 517
Telemetry [baseline] (14.253 ms) : 0, 14253
Telemetry [candidate] (14.374 ms) : 0, 14374
Flare Poller [baseline] (4.736 ms) : 0, 4736
Flare Poller [candidate] (4.695 ms) : 0, 4695
IAST [baseline] (25.079 ms) : 0, 25079
IAST [candidate] (25.331 ms) : 0, 25331
section profiling
ProfilingAgent [baseline] (94.577 ms) : 0, 94577
ProfilingAgent [candidate] (94.2 ms) : 0, 94200
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.164 ms) : 0, 1164
BytebuddyAgent [baseline] (686.0 ms) : 0, 686000
BytebuddyAgent [candidate] (680.763 ms) : 0, 680763
AgentMeter [baseline] (8.689 ms) : 0, 8689
AgentMeter [candidate] (8.605 ms) : 0, 8605
GlobalTracer [baseline] (216.779 ms) : 0, 216779
GlobalTracer [candidate] (214.923 ms) : 0, 214923
AppSec [baseline] (32.104 ms) : 0, 32104
AppSec [candidate] (31.966 ms) : 0, 31966
Debugger [baseline] (63.34 ms) : 0, 63340
Debugger [candidate] (62.232 ms) : 0, 62232
Remote Config [baseline] (593.428 µs) : 0, 593
Remote Config [candidate] (580.716 µs) : 0, 581
Telemetry [baseline] (10.682 ms) : 0, 10682
Telemetry [candidate] (10.486 ms) : 0, 10486
Flare Poller [baseline] (3.532 ms) : 0, 3532
Flare Poller [candidate] (4.28 ms) : 0, 4280
Profiling [baseline] (95.14 ms) : 0, 95140
Profiling [candidate] (94.759 ms) : 0, 94759
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~fdf878839c, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1065709
Total [baseline] (8.88 s) : 0, 8880223
Agent [candidate] (1.057 s) : 0, 1056858
Total [candidate] (8.826 s) : 0, 8826182
section iast
Agent [baseline] (1.223 s) : 0, 1223062
Total [baseline] (9.52 s) : 0, 9519728
Agent [candidate] (1.233 s) : 0, 1232982
Total [candidate] (9.55 s) : 0, 9549705
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~fdf878839c, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.215 ms) : 0, 1215
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (632.087 ms) : 0, 632087
BytebuddyAgent [candidate] (627.921 ms) : 0, 627921
AgentMeter [baseline] (29.372 ms) : 0, 29372
AgentMeter [candidate] (28.95 ms) : 0, 28950
GlobalTracer [baseline] (258.329 ms) : 0, 258329
GlobalTracer [candidate] (257.044 ms) : 0, 257044
AppSec [baseline] (31.946 ms) : 0, 31946
AppSec [candidate] (31.528 ms) : 0, 31528
Debugger [baseline] (59.176 ms) : 0, 59176
Debugger [candidate] (58.624 ms) : 0, 58624
Remote Config [baseline] (618.823 µs) : 0, 619
Remote Config [candidate] (589.889 µs) : 0, 590
Telemetry [baseline] (8.788 ms) : 0, 8788
Telemetry [candidate] (8.649 ms) : 0, 8649
Flare Poller [baseline] (7.875 ms) : 0, 7875
Flare Poller [candidate] (6.377 ms) : 0, 6377
section iast
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.203 ms) : 0, 1203
BytebuddyAgent [baseline] (793.352 ms) : 0, 793352
BytebuddyAgent [candidate] (800.735 ms) : 0, 800735
AgentMeter [baseline] (11.317 ms) : 0, 11317
AgentMeter [candidate] (11.532 ms) : 0, 11532
GlobalTracer [baseline] (246.831 ms) : 0, 246831
GlobalTracer [candidate] (248.175 ms) : 0, 248175
AppSec [baseline] (26.298 ms) : 0, 26298
AppSec [candidate] (26.491 ms) : 0, 26491
Debugger [baseline] (62.791 ms) : 0, 62791
Debugger [candidate] (63.058 ms) : 0, 63058
Remote Config [baseline] (533.46 µs) : 0, 533
Remote Config [candidate] (530.859 µs) : 0, 531
Telemetry [baseline] (14.699 ms) : 0, 14699
Telemetry [candidate] (15.382 ms) : 0, 15382
Flare Poller [baseline] (4.884 ms) : 0, 4884
Flare Poller [candidate] (4.384 ms) : 0, 4384
IAST [baseline] (25.076 ms) : 0, 25076
IAST [candidate] (25.315 ms) : 0, 25315
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 16 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~fdf878839c, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section baseline
no_agent (1.206 ms) : 1194, 1218
. : milestone, 1206,
iast (3.29 ms) : 3239, 3341
. : milestone, 3290,
iast_FULL (6.081 ms) : 6020, 6143
. : milestone, 6081,
iast_GLOBAL (3.594 ms) : 3539, 3649
. : milestone, 3594,
profiling (1.965 ms) : 1948, 1981
. : milestone, 1965,
tracing (1.831 ms) : 1816, 1847
. : milestone, 1831,
section candidate
no_agent (1.165 ms) : 1154, 1176
. : milestone, 1165,
iast (3.21 ms) : 3168, 3252
. : milestone, 3210,
iast_FULL (5.748 ms) : 5690, 5806
. : milestone, 5748,
iast_GLOBAL (3.48 ms) : 3421, 3538
. : milestone, 3480,
profiling (2.098 ms) : 2079, 2117
. : milestone, 2098,
tracing (1.776 ms) : 1759, 1793
. : milestone, 1776,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~fdf878839c, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section baseline
no_agent (17.954 ms) : 17770, 18138
. : milestone, 17954,
appsec (18.433 ms) : 18245, 18621
. : milestone, 18433,
code_origins (17.989 ms) : 17808, 18170
. : milestone, 17989,
iast (18.006 ms) : 17821, 18190
. : milestone, 18006,
profiling (19.298 ms) : 19101, 19495
. : milestone, 19298,
tracing (18.818 ms) : 18630, 19005
. : milestone, 18818,
section candidate
no_agent (17.999 ms) : 17811, 18187
. : milestone, 17999,
appsec (18.801 ms) : 18608, 18995
. : milestone, 18801,
code_origins (17.757 ms) : 17578, 17936
. : milestone, 17757,
iast (17.693 ms) : 17514, 17871
. : milestone, 17693,
profiling (18.631 ms) : 18441, 18822
. : milestone, 18631,
tracing (17.735 ms) : 17557, 17913
. : milestone, 17735,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~fdf878839c, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section baseline
no_agent (1.468 ms) : 1457, 1480
. : milestone, 1468,
appsec (2.571 ms) : 2511, 2630
. : milestone, 2571,
iast (2.257 ms) : 2187, 2327
. : milestone, 2257,
iast_GLOBAL (2.304 ms) : 2233, 2375
. : milestone, 2304,
profiling (2.524 ms) : 2303, 2745
. : milestone, 2524,
tracing (2.064 ms) : 2009, 2119
. : milestone, 2064,
section candidate
no_agent (1.468 ms) : 1456, 1479
. : milestone, 1468,
appsec (3.775 ms) : 3556, 3994
. : milestone, 3775,
iast (2.261 ms) : 2190, 2332
. : milestone, 2261,
iast_GLOBAL (2.3 ms) : 2229, 2371
. : milestone, 2300,
profiling (2.121 ms) : 2063, 2179
. : milestone, 2121,
tracing (2.079 ms) : 2023, 2134
. : milestone, 2079,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~fdf878839c, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section baseline
no_agent (14.9 s) : 14900000, 14900000
. : milestone, 14900000,
appsec (14.712 s) : 14712000, 14712000
. : milestone, 14712000,
iast (17.837 s) : 17837000, 17837000
. : milestone, 17837000,
iast_GLOBAL (17.786 s) : 17786000, 17786000
. : milestone, 17786000,
profiling (14.792 s) : 14792000, 14792000
. : milestone, 14792000,
tracing (15.256 s) : 15256000, 15256000
. : milestone, 15256000,
section candidate
no_agent (15.49 s) : 15490000, 15490000
. : milestone, 15490000,
appsec (14.889 s) : 14889000, 14889000
. : milestone, 14889000,
iast (18.208 s) : 18208000, 18208000
. : milestone, 18208000,
iast_GLOBAL (17.844 s) : 17844000, 17844000
. : milestone, 17844000,
profiling (15.055 s) : 15055000, 15055000
. : milestone, 15055000,
tracing (14.96 s) : 14960000, 14960000
. : milestone, 14960000,
|
- Fix MetadataState class name to use fully qualified name in KafkaProducerInstrumentation (helperClassNames and contextStore), which was causing producer spans to break due to context store mismatch - Replace sensitive keys denylist with an allowlist of safe config keys - Mask values of non-allowed keys with "****" instead of dropping them, to enable monitoring of which configs are seen but not yet allowed Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fd826ee to
1ecfe51
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
In Groovy, `map[expr1] = expr2` evaluates expr2 before expr1, which swapped msgpack key/value reads. Use temp variables instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move test to default package to avoid underscore in package name, matching the convention used by other kafka test files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.