Feature/ni 161 - Meteoalarm message post#75
Merged
teddmason merged 16 commits intodevelopmentfrom Apr 2, 2026
Merged
Conversation
teddmason
force-pushed
the
feature/NI-161
branch
from
aa4166b to
6f3b45e
Compare
…e process as it is integral to future of the service
pwadmore-ea
requested changes
Feb 20, 2026
pwadmore-ea
previously approved these changes
Feb 24, 2026
pwadmore-ea
previously approved these changes
Feb 25, 2026
* Adding in additional logging, based from NI-161 * sonarcloud issues * stripping out some logging, and fixing a twice declared var
|
pwadmore-ea
approved these changes
Apr 1, 2026
Comment on lines
+17
to
+34
| console.log(`[getMessage] Cache HIT for ${key}`) | ||
| body = v2 ? cachedMessage.alert_v2 : cachedMessage.alert | ||
| console.log(`[getMessage] Message retrieved in ${Date.now() - fetchStart}ms for ${key}`) | ||
| return body | ||
| } | ||
|
|
||
| console.log(`[getMessage] Cache MISS for ${key}, fetching from database`) | ||
| const ret = await service.getMessage(key) | ||
| if (!ret?.rows || !Array.isArray(ret.rows) || ret.rows.length < 1 || !ret.rows[0].getmessage) { | ||
| console.log('[getMessage] No message found for ' + key) | ||
| throw new Error('No message found') | ||
| } | ||
| const message = ret.rows[0].getmessage | ||
| body = v2 ? message.alert_v2 : message.alert | ||
| // Cache the message in redis | ||
| await redis.set(key, message) | ||
| console.log(`[getMessage] Retrieved from database and cached: ${key}`) | ||
| console.log(`[getMessage] Message retrieved in ${Date.now() - fetchStart}ms for ${key}`) |
Contributor
There was a problem hiding this comment.
Should [getMessage] be replaced with [fetchMessageBody] so log entries reflect the correct function name? As fetchMessageBody is an internal function called from the getMessage function I'm happy with either approach and will approve the pull request.
Member
Author
There was a problem hiding this comment.
The prefix was just meant to match the overarching lambda function that was invoked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.