feat: add properties for licenses according to CycloneDX 1.5#947
Conversation
Documentation build overview
Show files changed (2 files in total): 📝 2 modified | ➕ 0 added | ➖ 0 deleted
|
jkowalleck
left a comment
There was a problem hiding this comment.
Thank you for taking care of this.
there is a thing that needs chaning.
|
@peschuster , according to https://github.com/CycloneDX/cyclonedx-python-lib/actions/runs/23154706928/job/67267559075?pr=947, |
4258e99 to
8053ebc
Compare
I updated the commit with the changes suggested in the review. I also checked pyupgrade again and noticed that the command in tox.ini does not work on Windows. This meant that it did not change anything before. However, running pyupgrade with a Windows-specific command worked, and I hope this issue has now been resolved as well. |
fantastic! what was this windows-specific command you used? |
|
there is a flake8 violation: https://github.com/CycloneDX/cyclonedx-python-lib/actions/runs/23158846467/job/67367320116?pr=947#step:6:183
could you fix this, too? |
Signed-off-by: Peter Schuster <p.schuster@pilz.de>
8053ebc to
7e3018c
Compare
I will do that. However, I had to extract the "glob" logic into a separate python script to make it cross platform. |
This change adds properties to DisjunctiveLicense according to CycloneDX v1.5
Related to / implements a part of issue #578
AI Tool Disclosure
[e.g. GitHub CoPilot, ChatGPT, JetBrains Junie etc.][e.g. GPT-4.1, Claude Haiku 4.5, Gemini 2.5 Pro etc.][Summarize the key prompts or instructions given to the AI tools]Affirmation