Provide additional Details for Webhook Operations#55
Open
hexa2k9 wants to merge 2 commits intoCyclenerd:masterfrom
Open
Provide additional Details for Webhook Operations#55hexa2k9 wants to merge 2 commits intoCyclenerd:masterfrom
hexa2k9 wants to merge 2 commits intoCyclenerd:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First off, thanks for taking the time to contribute!
Please Complete the Following
Notes
This will return the affected Runner Name in Webhook Operations and add the X-GitHub-Delivery Header to Logs to build a correlation between GitHub Webhook Requests and the Operations on Compute Engine.
We had some concurrency issues a little while ago and I needed to get additional Details from the Point that I wasn't able to identity which operations have been caused by which Webhook Delivery and which Webhooks haven't been delivered for which reason.
--
Example Response Payload (we use full length uuid v7 for runner names):
{"action":"deleted","runner_name":"runner-019d3e12-1434-75f8-8caa-6284eb790d05","status":"success"}Which was logged in Cloud Run as the following: