Skip to content

Add functionality to turn off monitoring status of Models launched#788

Open
rickybalin wants to merge 41 commits intoCrayLabs:developfrom
rickybalin:feature/monitor_model
Open

Add functionality to turn off monitoring status of Models launched#788
rickybalin wants to merge 41 commits intoCrayLabs:developfrom
rickybalin:feature/monitor_model

Conversation

@rickybalin
Copy link
Copy Markdown
Contributor

This PR adds the ability to turn off monitoring of Models launched with experiment.start() by modifying the Controller and JobManager classes. With this update, experiment.start() takes an additional boolean argument determining whether to monitor the particular model or not. The argument is set to True by default, so it should not require any changes for the default behavior of monitoring all Models launched.

The PR also adds a method to PalsMpiexecSettings called set_launcher_args() to be able to add any launcher arguments to the mpiexec command.

rickybalin and others added 22 commits October 28, 2022 14:05
…ded when sharing GPU between different applications running with the co-located database deployment.
Fully sync fork with the official SmartSim develop branch
@al-rigazzi al-rigazzi self-requested a review July 2, 2025 22:22
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.17%. Comparing base (d7d979e) to head (a62e971).
⚠️ Report is 25 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #788      +/-   ##
===========================================
- Coverage    83.91%   80.17%   -3.74%     
===========================================
  Files           83       78       -5     
  Lines         6284     6093     -191     
===========================================
- Hits          5273     4885     -388     
- Misses        1011     1208     +197     
Files with missing lines Coverage Δ
smartsim/_core/control/controller.py 82.98% <100.00%> (-2.25%) ⬇️
smartsim/_core/control/jobmanager.py 93.75% <100.00%> (-0.41%) ⬇️
smartsim/experiment.py 85.02% <ø> (-0.86%) ⬇️

... and 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@al-rigazzi al-rigazzi removed their request for review March 4, 2026 09:14
@rickybalin rickybalin marked this pull request as ready for review March 20, 2026 05:50
@rickybalin
Copy link
Copy Markdown
Contributor Author

rickybalin commented Mar 20, 2026

@ashao, could I get some help getting this PR reviewed and merged? We need it for some functionality to stand up a "persistent" colocated DB, to which applications can connect and disconnect during a workflow. Thanks!

Please let me know if there are any issues.

@MattToast MattToast requested a review from ashao March 25, 2026 12:57
Co-authored-by: Matt Drozt <matthew.drozt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants