Closed
Conversation
Member
|
Fixed as part of #2650 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #2630
Proposed changes
This PR fixes incorrect rendering of tuplet labels when importing MusicXML files.
Root cause: MusicXmlImporter parsed for note duration correctly, but completely ignored the element inside. As a result, the
show-numberandbracketattributes were never read, andLineBarRendererhad no way to distinguish between tuplets that should display a label and those that should not.TupletShowNumberenum (Actual/Both/None ) representing the three states of the MusicXML show-number attributeshowTupletNumber: TupletShowNumberandshowTupletBracket: booleanfields to Beat, both defaulting to safe backward-compatible valuesMusicXmlImporter._parseTupletVisibilityto read and store show-number and bracket on the corresponding beatLineBarRenderer._paintTupletHelperwith an algorithmic natural-denominator rule.Example fixed cases:
show-number="none" bracket="no"are now fully suppressed instead of rendering a phantom 12:27 labelChecklist
Some reference images for current tests need to be updated.
Further details