-
-
Notifications
You must be signed in to change notification settings - Fork 336
London | 26-ITP-Jan | Zadri Abdule | Sprint 3 | coursework practice tdd #1271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
7e6b8d8
60369d6
50749d9
97a5210
761fb1d
bfe3ee4
1d62341
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,13 @@ | ||
| function countChar(stringOfCharacters, findCharacter) { | ||
| return 5 | ||
| let count = 0; | ||
| for (let i = 0; i < stringOfCharacters.length; i++) { | ||
| if (stringOfCharacters[i] === findCharacter) { | ||
| count++; | ||
| } | ||
| } | ||
|
|
||
| return count; | ||
| } | ||
|
|
||
|
|
||
| module.exports = countChar; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,25 @@ | ||
| // - Input: any Number (finite or not). Non-finite values (NaN, Infinity) are stringified. | ||
| // - Behaviour: uses the ingteger part (Math.trunc) so descimals are truncated (e.g. 4.9 -> 4). | ||
| // - Negative numbers keep their sign (e.g. -3 -> '-3rd'). | ||
| // - Special case: 11, 12, 13 always use 'th. | ||
| // - Output: a string like '1st', '2nd', '11th' 0r 'NaN'/'Infinity' for non-finite input. | ||
|
|
||
|
|
||
|
|
||
| function getOrdinalNumber(num) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since it's a number, it could be negative or a float (decimal). |
||
| return "1st"; | ||
| if (!Number.isFinite(num)) return String(num); | ||
| const sign = num < 0 ? '-' : ''; | ||
| const i = Math.trunc(Math.abs(num)); | ||
| const lastTwo = i % 100; | ||
| if (lastTwo >= 11 && lastTwo <= 13) return sign + i + 'th'; | ||
|
|
||
|
|
||
| switch (i % 10) { | ||
| case 1: return sign + i + 'st; | ||
| case 2: return sign + i + 'nd'; | ||
| case 3: return sign + i + 'rd'; | ||
| default: return sign + i + 'th'; | ||
| } | ||
| } | ||
|
|
||
| module.exports = getOrdinalNumber; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,4 +17,42 @@ test("should append 'st' for numbers ending with 1, except those ending with 11" | |
| expect(getOrdinalNumber(1)).toEqual("1st"); | ||
| expect(getOrdinalNumber(21)).toEqual("21st"); | ||
| expect(getOrdinalNumber(131)).toEqual("131st"); | ||
|
|
||
| }); | ||
|
|
||
| // Case 2: Numbers ending with 2 (but not 12) | ||
| // When the number ends with 2, except those ending with 12, | ||
| // Then the function should return a string by appending "nd" to the number. | ||
| test("should append 'nd' for numbers ending with 2, except those ending with 12", () => { | ||
| expect(getOrdinalNumber(2)).toEqual("2nd"); | ||
| expect(getOrdinalNumber(22)).toEqual("22nd"); | ||
| expect(getOrdinalNumber(132)).toEqual("132nd"); | ||
| }); | ||
|
|
||
| // Case 3: Numbers ending with 3 (but not 13) | ||
| // When the case ends with 3, expect those ending with 13 | ||
| // Then the function should return a string by appending "rd" to the number. | ||
| test("should append 'rd' for numbers ending with 3, except those ending with 13", () => { | ||
| expect(getOrdinalNumber(3)).toEqual("3rd"); | ||
| expect(getOrdinalNumber(23)).toEqual("23rd"); | ||
| expect(getOrdinalNumber(133)).toEqual("133rd"); | ||
| }); | ||
|
|
||
| // Case 4: Numbers ending with 11, 12, or 13 | ||
| // When the number ends with 11, 12, or 13, | ||
| // Then the function should return a string by appending "th" to the number. | ||
| test("should append 'th' for numbers ending with 11, 12, or 13", () => { | ||
| expect(getOrdinalNumber(11)).toEqual("11th"); | ||
| expect(getOrdinalNumber(12)).toEqual("12th"); | ||
| expect(getOrdinalNumber(13)).toEqual("13th"); | ||
| }); | ||
|
|
||
| // Case 5: ALL other numbers | ||
| // When the number does not end with 1, 2, 3, 11, 12, or 13, | ||
| // Then the function should return a string by appending "th" to the number. | ||
| test("should append 'th' for all other numbers", () => { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Might be worth adjusting this test to be more specific, as 'all other numbers' failing won't tell us which numbers they are? Other tests look great!
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks. I'll make sure to adjust it. |
||
| expect(getOrdinalNumber(4)).toEqual("4th"); | ||
| expect(getOrdinalNumber(10)).toEqual("10th"); | ||
| expect(getOrdinalNumber(14)).toEqual("14th"); | ||
| expect(getOrdinalNumber(100)).toEqual("100th"); | ||
| }); | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if the string
stringOfCharacterswas not provided at all? What if it's undefined, or null?You should take into account where your code could produce an error and account for that.
How do you think you'd account for those scenarios?