Sheffield | 26-ITP-Jan | Seti Mussa | Sprint 2 | Data Group by Seti-Jemal · Pull Request #1172 · CodeYourFuture/Module-Data-Groups

Seti-Jemal · 2026-04-03T22:49:34Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I have answered the task as required.

cjyuan · 2026-04-04T23:32:03Z

Sprint-2/debug/recipe.js

 console.log(`${recipe.title} serves ${recipe.serves}
  ingredients:
-${recipe}`);
+${recipe.ingredients.join('\n  ')}`);


Why place two extra space in the separator?

cjyuan · 2026-04-04T23:32:50Z

Sprint-2/implement/contains.js

+    return false;
+  }
+
+  return Object.prototype.hasOwnProperty.call(obj, prop);


Can also explore Object.hasOwn().

cjyuan · 2026-04-04T23:37:05Z

Sprint-2/implement/contains.test.js

 // Given invalid parameters like an array
 // When passed to contains
 // Then it should return false or throw an error
+test("return false for invalid input like an array", () => {
+  expect(contains([], "a")).toBe(false);
+});


This test does not yet confirm that the function correctly returns false when the first argument is an array.
This is because contains([], "a") could also return false simply because "a" is not a key of the array.

Arrays are objects, with their indices acting as keys. A proper test should use a non-empty array along with a valid key to ensure the function returns false specifically because the input is an array, not because the key is missing.

cjyuan · 2026-04-04T23:40:04Z

Sprint-2/implement/querystring.js

+    const index = pair.indexOf("=");
+    if (index === -1) continue;


FYI: "key1&key2" is also a valid query string.

No change required.

cjyuan · 2026-04-04T23:41:11Z

Sprint-2/implement/tally.js

+
+  const counts = {};
+
+  for (const item of items) {
+    counts[item] = (counts[item] || 0) + 1;
+  }


Does the following function call return the value you expect?

tally(["toString", "toString"]);

Suggestion: Look up an approach to create an empty object with no inherited properties.

cjyuan · 2026-04-04T23:48:13Z

Sprint-2/stretch/mode.js

Have you tried running this script or the tests in mode.test.js?

cjyuan · 2026-04-04T23:51:41Z

Sprint-2/stretch/till.js

+  let total = 0;
+
+  for (const [coin, quantity] of Object.entries(till)) {
+    const value = parseInt(coin);


Can you explain why you choose to use parseInt(coin) instead of Number(coin)?

Seti-Jemal added 5 commits April 1, 2026 14:38

Fixed the object property access to houseNumber

edfc2fb

Added the object.value() to print all the value of object

1a35459

Add contain function

9786cba

I have completed sprint 2

8bf4cdc

Complete sprint -2

253ebd0