Skip to content

Glasgow | Jan-26 | Alasdair MacDonald | Sprint 3 | Reading List #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MacDonald91 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Glasgow | Jan-26 | Alasdair MacDonald | Sprint 3 | Reading List #1041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sprint-3/reading-list/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" href="style.css" />
<title>Title here</title>
<title>Reading List</title>
</head>
<body>
<div id="content">
Expand Down
28 changes: 28 additions & 0 deletions Sprint-3/reading-list/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,31 @@ const books = [
},
];

const list = document.getElementById("reading-list");

books.forEach((book) => {
const li = document.createElement("li");

// Add title + author (text must exist for tests)
li.textContent = `${book.title} by ${book.author}`;

// Create image
const img = document.createElement("img");
img.src = book.bookCoverImage;

// IMPORTANT: ensures exact HTML match for tests
img.setAttribute("src", book.bookCoverImage);
Copy link
Copy Markdown

@WeiTsungCheng WeiTsungCheng Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

img.src = book.bookCoverImage;
img.setAttribute("src", book.bookCoverImage);

why do twice?


// Add image to list item
li.appendChild(img);

// Set background colour based on read status
if (book.alreadyRead) {
li.style.backgroundColor = "green";
} else {
li.style.backgroundColor = "red";
}

// Add to page
list.appendChild(li);
});
Loading